From: Hamish Moffatt <hamish@cloud.net.au>
To: buildroot@busybox.net
Subject: [Buildroot] patch to allow selection of e2fsprogs tools toinstall
Date: Thu, 21 Feb 2008 16:20:15 +1100 [thread overview]
Message-ID: <20080221052015.GA31271@cloud.net.au> (raw)
In-Reply-To: <007501c87443$5565b9a0$040514ac@atmel.com>
On Thu, Feb 21, 2008 at 05:36:25AM +0100, Ulf Samuelsson wrote:
> That doesn't work so I assume it was never tested.
> Pls test before you resubmit.
I did, and it works for me.
> $(E2FSPROGS_RM) is always clear
> $(E2FSPROGS_RM-y) and $(E2FSPROGS_RM-n) may have contents.
No,
> > +E2FSPROGS_RM$(strip $(BR2_PACKAGE_E2FSPROGS_BADBLOCKS)) += ${TARGET_DIR}/sbin/badblocks
> > +E2FSPROGS_RM$(strip $(BR2_PACKAGE_E2FSPROGS_BLKID)) += ${TARGET_DIR}/sbin/blkid
$(E2FSPROGS_RM-*) is not used, it is $(E2FSPROGS_RM)y and
$(E2FSPROGS_RM). I could have used RM-, but I thought $(E2FSPROGS_RM-)
looked odd.
Hence,
> > +ifneq ($(strip $(E2FSPROGS_RM)),)
> > + rm -rf $(E2FSPROGS_RM)
> > +endif
Hamish
--
Hamish Moffatt VK3SB <hamish@debian.org> <hamish@cloud.net.au>
prev parent reply other threads:[~2008-02-21 5:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-20 6:18 [Buildroot] patch to allow selection of e2fsprogs tools to install Hamish Moffatt
2008-02-20 6:28 ` Ulf Samuelsson
2008-02-21 1:38 ` Hamish Moffatt
2008-02-21 4:36 ` [Buildroot] patch to allow selection of e2fsprogs tools toinstall Ulf Samuelsson
2008-02-21 5:20 ` Hamish Moffatt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080221052015.GA31271@cloud.net.au \
--to=hamish@cloud.net.au \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.