From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Egger Subject: Re: [PATCH] blktap: qcow2 image format support Date: Thu, 21 Feb 2008 10:07:14 +0100 Message-ID: <200802211007.14443.Christoph.Egger@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Kevin Wolf List-Id: xen-devel@lists.xenproject.org On Thursday 21 February 2008 09:57:48 Keir Fraser wrote: > On 21/2/08 08:49, "Kevin Wolf" wrote: > > This patch adds support for the qcow2 image format to blktap. It > > consists mostly of qemu code, adapted to the blktap interfaces. > > Snapshots and compressed images are supported. > > > > The qcow2 driver may be used by either specifying tap:qcow2 or by using > > tap:qcow which will detect that you have a version 2 image and will call > > the qcow2 driver. > > Is qcow2 so different from qcow1 that it really needs its own backend > driver? IMO, _all_ blktap drivers need some code refactoring. There is a lot of duplicated code across all drivers that can be moved into a blktap/drivers/blk-common.c. Christoph =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy