All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Starikovskiy <astarikovskiy@suse.de>
To: LenBrown <lenb@kernel.org>
Cc: Linux-acpi@vger.kernel.orgLinux-acpi@vger.kernel.org
Subject: [PATCH] ACPI: suspend: clear leftovers from S4BIOS.
Date: Thu, 21 Feb 2008 18:09:35 +0300	[thread overview]
Message-ID: <20080221150935.20302.30835.stgit@thinkpad> (raw)

S4BIOS is not supported, so there is no reason to expect 
it as input and try to do something wrong.

Signed-off-by: Alexey Starikovskiy <astarikovskiy@suse.de>
---

 drivers/acpi/sleep/main.c |    2 --
 drivers/acpi/sleep/proc.c |    5 -----
 2 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/drivers/acpi/sleep/main.c b/drivers/acpi/sleep/main.c
index 293a1cb..3e85a68 100644
--- a/drivers/acpi/sleep/main.c
+++ b/drivers/acpi/sleep/main.c
@@ -403,8 +403,6 @@ int acpi_suspend(u32 acpi_state)
 
 	if (acpi_state < 6 && states[acpi_state])
 		return pm_suspend(states[acpi_state]);
-	if (acpi_state == 4)
-		return hibernate();
 	return -EINVAL;
 }
 
diff --git a/drivers/acpi/sleep/proc.c b/drivers/acpi/sleep/proc.c
index f8df521..f530757 100644
--- a/drivers/acpi/sleep/proc.c
+++ b/drivers/acpi/sleep/proc.c
@@ -60,11 +60,6 @@ acpi_system_write_sleep(struct file *file,
 	if (copy_from_user(str, buffer, count))
 		return -EFAULT;
 
-	/* Check for S4 bios request */
-	if (!strcmp(str, "4b")) {
-		error = acpi_suspend(4);
-		goto Done;
-	}
 	state = simple_strtoul(str, NULL, 0);
 #ifdef CONFIG_HIBERNATION
 	if (state == 4) {


             reply	other threads:[~2008-02-21 15:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-21 15:09 Alexey Starikovskiy [this message]
2008-02-21 15:51 ` [PATCH] ACPI: suspend: clear leftovers from S4BIOS Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080221150935.20302.30835.stgit@thinkpad \
    --to=astarikovskiy@suse.de \
    --cc=Linux-acpi@vger.kernel.orgLinux-acpi \
    --cc=lenb@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.