Re: [PATCH] Wrap buffers used for rpc debug printks into RPC_IFDEBUG

["J. Bruce Fields" <bfields@fieldses.org>]

On Thu, Feb 21, 2008 at 04:45:22PM -0500, Trond Myklebust wrote:
> 
> On Thu, 2008-02-21 at 10:57 +0300, Pavel Emelyanov wrote:
> > Sorry for the noise, but here's the v3 of this compilation fix :)
> > 
> > There are some places, which declare the char buf[...] on the stack
> > to push it later into dprintk(). Since the dprintk sometimes (if the 
> > CONFIG_SYSCTL=n) becomes an empty do { } while (0) stub, these buffers
> > cause gcc to produce appropriate warnings.
> > 
> > Wrap these buffers with RPC_IFDEBUG macro, as Trond proposed, to 
> > compile them out when not needed.
> > 
> > Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
> 
> Thanks Pavel!

Yes, thanks Pavel for persisting--it looks very straightforward to me
this way.

> 
> Bruce, do you want to shepherd this in, or should I? I'm planning on
> pushing a couple of bugfixes to Linus this evening anyway...

That would be great; feel free to add an

	Acked-by: J. Bruce Fields <bfields@citi.umich.edu>

if you want.

--b.