All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pavel Roskin <proski@gnu.org>
To: linux-wireless@vger.kernel.org, at76c503a-develop@lists.berlios.de
Subject: [PATCH 1/5] at76_usb: fix missing newlines in printk, improve some messages
Date: Fri, 22 Feb 2008 00:00:44 -0500	[thread overview]
Message-ID: <20080222050044.11158.86655.stgit@dv.roinet.com> (raw)

It's important to know which function failed.

Signed-off-by: Pavel Roskin <proski@gnu.org>
---

 drivers/net/wireless/at76_usb.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/at76_usb.c b/drivers/net/wireless/at76_usb.c
index 8db15bd..cdc258e 100644
--- a/drivers/net/wireless/at76_usb.c
+++ b/drivers/net/wireless/at76_usb.c
@@ -1645,7 +1645,7 @@ static struct fwentry *at76_load_firmware(struct usb_device *udev,
 			   fwe->fwname);
 		dev_printk(KERN_ERR, &udev->dev,
 			   "you may need to download the firmware from "
-			   "http://developer.berlios.de/projects/at76c503a/");
+			   "http://developer.berlios.de/projects/at76c503a/\n");
 		goto exit;
 	}
 
@@ -1885,7 +1885,7 @@ static int at76_join(struct at76_priv *priv)
 				    sizeof(struct at76_req_join));
 
 	if (ret < 0) {
-		printk(KERN_ERR "%s: CMD_JOIN failed: %d",
+		printk(KERN_ERR "%s: at76_set_card_command failed: %d\n",
 		       wiphy_name(priv->hw->wiphy), ret);
 		return 0;
 	}
@@ -1893,7 +1893,7 @@ static int at76_join(struct at76_priv *priv)
 	ret = at76_wait_completion(priv, CMD_JOIN);
 	at76_dbg(DBG_MAC80211, "%s: CMD_JOIN returned: 0x%02x", __func__, ret);
 	if (ret != CMD_STATUS_COMPLETE) {
-		printk(KERN_ERR "%s: CMD_JOIN failed: %d",
+		printk(KERN_ERR "%s: at76_wait_completion failed: %d\n",
 		       wiphy_name(priv->hw->wiphy), ret);
 		return 0;
 	}

             reply	other threads:[~2008-02-22  5:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-22  5:00 Pavel Roskin [this message]
2008-02-22  5:00 ` [PATCH 2/5] at76_usb: remove unneeded code Pavel Roskin
2008-02-22  5:00 ` [PATCH 3/5] at76_usb: add more MODULE_AUTHOR entries Pavel Roskin
2008-02-22  5:01 ` [PATCH 4/5] at76_usb: reindent, reorder initializers for readability Pavel Roskin
2008-02-22  5:01 ` [PATCH 5/5] at76_usb: make the driver depend on MAC80211 Pavel Roskin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080222050044.11158.86655.stgit@dv.roinet.com \
    --to=proski@gnu.org \
    --cc=at76c503a-develop@lists.berlios.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.