From: Robin Holt <holt@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: [PATCH 04/28] ia64/xen: introduce synch bitops which is
Date: Fri, 22 Feb 2008 05:42:28 +0000 [thread overview]
Message-ID: <20080222054228.GM11391@sgi.com> (raw)
In-Reply-To: <12036570474076-git-send-email-yamahata@valinux.co.jp>
On Fri, Feb 22, 2008 at 02:10:20PM +0900, Isaku Yamahata wrote:
...
> --- /dev/null
> +++ b/include/asm-ia64/sync_bitops.h
> @@ -0,0 +1,61 @@
> +#ifndef __XEN_SYNC_BITOPS_H__
> +#define __XEN_SYNC_BITOPS_H__
Typically, these #defines are made to match the filename.
...
> +#define ADDR (*(volatile long *) addr)
This seems like a leftover #define. Additionally, ADDR seems a bit
vague and easily misused. Since I don't see it used anywhere else in
that patch, I will assume it should be tossed, but reserve the right to
rescind this comment later.
...
> +#endif /* __XEN_SYNC_BITOPS_H__ */
Same as the first.
Thanks,
Robin
next prev parent reply other threads:[~2008-02-22 5:42 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 5:10 [PATCH 00/28] RFC: ia64/xen domU paravirtualization Isaku Yamahata
2008-02-22 5:10 ` [PATCH 03/28] ia64/xen: increase IA64_MAX_RSVD_REGIONS Isaku Yamahata
2008-02-22 5:33 ` Robin Holt
2008-02-22 6:02 ` Isaku Yamahata
2008-02-22 6:02 ` Isaku Yamahata
2008-02-25 17:18 ` Bjorn Helgaas
2008-02-26 1:57 ` Isaku Yamahata
2008-02-22 5:10 ` [PATCH 04/28] ia64/xen: introduce synch bitops which is necessary for ia64/xen support Isaku Yamahata
2008-02-22 5:42 ` Robin Holt [this message]
2008-02-22 6:13 ` Isaku Yamahata
2008-02-22 6:13 ` Isaku Yamahata
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222054228.GM11391@sgi.com \
--to=holt@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.