From: Alexandre Boeglin <alex@boeglin.org>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h
Date: Fri, 22 Feb 2008 08:49:52 +0100 [thread overview]
Message-ID: <20080222074952.GA16785@boeglin.org> (raw)
In-Reply-To: <200802212208.56286.okuji@enbug.org>
Le jeu 21 fév 2008 à 22:08:55 +0100, Yoshinori K. Okuji a écrit :
> On Sunday 17 February 2008 12:52, Alexandre Boeglin wrote:
> > This small patch fixes grub_get_rtc on EFI architecture. If I understood
> > correctly, one minute is 60000 milliseconds, not 3600.
>
> Nope. What's wrong here is the comment but not the code. It should read "This
> is destined to overflow when one hour passes by."
Then, I think the problem is the same, as the current grub_get_rtc returns a
number of milliseconds. So, shouldn'it be 60 * 60 * 1000 ?
Alex
next prev parent reply other threads:[~2008-02-22 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-17 11:52 [PATCH] fix GRUB_TICKS_PER_SECOND in include/grub/efi/time.h Alexandre Boeglin
2008-02-17 12:15 ` Alexandre Boeglin
2008-02-17 14:55 ` Alexandre Boeglin
2008-02-21 18:53 ` Alexandre Boeglin
2008-02-21 21:16 ` Yoshinori K. Okuji
2008-02-21 21:08 ` Yoshinori K. Okuji
2008-02-22 7:49 ` Alexandre Boeglin [this message]
2008-02-22 8:24 ` Yoshinori K. Okuji
2008-02-29 12:52 ` Alexandre Boeglin
2008-03-01 17:30 ` Yoshinori K. Okuji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222074952.GA16785@boeglin.org \
--to=alex@boeglin.org \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.