From: Sam Ravnborg <sam@ravnborg.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: James Morris <jmorris@namei.org>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: Regression [Was: Boot hang with stack protector on x86_64]
Date: Fri, 22 Feb 2008 17:12:56 +0100 [thread overview]
Message-ID: <20080222161256.GA1773@uranus.ravnborg.org> (raw)
In-Reply-To: <alpine.LFD.1.00.0802220739430.19896@woody.linux-foundation.org>
On Fri, Feb 22, 2008 at 07:43:08AM -0800, Linus Torvalds wrote:
>
>
> On Fri, 22 Feb 2008, Sam Ravnborg wrote:
> >
> > This is a regression. Can you please revert this commit.
>
> Not really. The thing is, CONFIG_CC_STACKPROTECTOR has never done anything
> at all, now it does, and it shows that it never worked.
And this made a machine non-bootable that could boot before.
>
> So the commit that made it do something shouldn't be reverted, but
> CONFIG_CC_STACKPROTECTOR should be marked BROKEN, because it obviously is
> broken right now.
>
> But keeping the config option, and just not making it do anything is
> misleading and wrong.
>
> So just something like this? To make sure normal people don't enable it..
Whatever is fine with me - I hope Ingo & Co fixes the root cause soon so
we can get the right fix in.
Sam
prev parent reply other threads:[~2008-02-22 16:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 0:29 Boot hang with stack protector on x86_64 James Morris
2008-02-22 1:14 ` Arjan van de Ven
2008-02-22 7:59 ` Regression [Was: Boot hang with stack protector on x86_64] Sam Ravnborg
2008-02-22 9:36 ` Ingo Molnar
2008-02-22 10:33 ` James Morris
2008-02-22 12:17 ` Ingo Molnar
2008-02-22 13:02 ` James Morris
2008-02-22 13:27 ` Ingo Molnar
2008-02-23 6:18 ` Ingo Molnar
2008-02-23 7:37 ` Ingo Molnar
2008-02-24 22:53 ` James Morris
2008-02-25 8:23 ` Ingo Molnar
2008-02-22 15:43 ` Linus Torvalds
2008-02-22 15:59 ` Arjan van de Ven
2008-02-22 16:12 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080222161256.GA1773@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=arjan@infradead.org \
--cc=hpa@zytor.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.