From: Andrew Morton <akpm@linux-foundation.org>
To: Eric Dumazet <dada1@cosmosbay.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux kernel <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org, Christoph Lameter <clameter@sgi.com>,
"Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
Subject: Re: [PATCH] alloc_percpu() fails to allocate percpu data
Date: Sat, 23 Feb 2008 00:04:48 -0800 [thread overview]
Message-ID: <20080223000448.9dadd2c5.akpm@linux-foundation.org> (raw)
In-Reply-To: <47BDBC23.10605@cosmosbay.com>
On Thu, 21 Feb 2008 19:00:03 +0100 Eric Dumazet <dada1@cosmosbay.com> wrote:
> +#ifndef cache_line_size
> +#define cache_line_size() L1_CACHE_BYTES
> +#endif
argh, you made me look.
Really cache_line_size() should be implemented in include/linux/cache.h.
Then we tromp the stupid private implementations in slob.c and slub.c.
Then we wonder why x86 uses a custom cache_line_size(), but still uses
L1_CACHE_BYTES for its L1_CACHE_ALIGN().
Once we've answered that, we look at your
+ /*
+ * We should make sure each CPU gets private memory.
+ */
+ size = roundup(size, cache_line_size());
and wonder whether it should have used L1_CACHE_ALIGN().
I think I'd better stop looking.
next prev parent reply other threads:[~2008-02-23 8:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-21 18:00 [PATCH] alloc_percpu() fails to allocate percpu data Eric Dumazet
2008-02-21 22:26 ` Peter Zijlstra
2008-02-23 9:23 ` Nick Piggin
2008-02-27 19:44 ` Christoph Lameter
2008-03-03 3:14 ` Nick Piggin
2008-03-03 7:48 ` Eric Dumazet
2008-03-03 9:41 ` Nick Piggin
2008-03-03 19:30 ` Christoph Lameter
2008-02-23 8:04 ` Andrew Morton [this message]
2008-02-27 19:59 ` Christoph Lameter
2008-02-27 20:24 ` Andrew Morton
2008-02-27 21:56 ` Christoph Lameter
2008-03-01 13:53 ` Eric Dumazet
2008-03-11 18:15 ` Mike Snitzer
2008-03-11 18:41 ` Eric Dumazet
2008-03-11 19:39 ` Mike Snitzer
2008-03-12 0:18 ` [stable] " Chris Wright
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223000448.9dadd2c5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=dada1@cosmosbay.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.