From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: adaplas@pol.net, linux-fbdev-devel@lists.sourceforge.net,
Jaya Kumar <jayakumar.lkml@gmail.com>
Subject: Re: [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb v3
Date: Sat, 23 Feb 2008 00:07:05 -0800 [thread overview]
Message-ID: <20080223000705.9c5eda0f.akpm@linux-foundation.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0802181502550.12244@anakin>
On Mon, 18 Feb 2008 15:03:08 +0100 (CET) Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> On Mon, 18 Feb 2008, Jaya Kumar wrote:
> > This patch implements support for the E-Ink Metronome controller. It
> > provides an mmapable interface to the controller using defio support.
> >
> > I welcome your feedback. Please let me know if it looks okay to apply.
>
> To me it looks OK.
>
It doesn't to me - I think I found several issues.
Please, silence is preferable to a quick scan and a poor ack.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2008.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
next prev parent reply other threads:[~2008-02-23 8:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-18 13:41 [PATCH 1/1 2.6.24] fbdev: defio and Metronomefb v3 Jaya Kumar
2008-02-18 14:03 ` Geert Uytterhoeven
2008-02-20 13:18 ` Jaya Kumar
2008-02-20 13:35 ` Andrew Morton
2008-02-20 13:46 ` Jaya Kumar
2008-02-20 23:28 ` Andrew Morton
2008-02-23 8:07 ` Andrew Morton [this message]
2008-02-23 8:07 ` Andrew Morton
2008-02-23 11:05 ` Jaya Kumar
2008-02-23 11:17 ` Jaya Kumar
2008-02-28 18:54 ` Jaya Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223000705.9c5eda0f.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=adaplas@pol.net \
--cc=geert@linux-m68k.org \
--cc=jayakumar.lkml@gmail.com \
--cc=linux-fbdev-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.