From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
eklhad@comcast.net
Subject: Re: input: put ledstate in the keyboard notifier
Date: Sat, 23 Feb 2008 15:24:55 +0100 [thread overview]
Message-ID: <20080223142455.GH4244@implementation> (raw)
Oh, I just noticed that Karl Dahlke's patch to provide the ledstate got
into -mm. Unfortunately, it is a bit bogus, see patch below, to be
applied on top of Karl's one.
Samuel
Keyboard notification ledstate fixes.
In keyboard notifications, use kbd->ledflagstate instead of
getledstate() since that's what the keyboard layer is supposed to use.
Update param.ledstate again between key handler call and notifying
KBD_POST_KEYSYM, since key handlers may update the led state.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
--- linux/drivers/char/keyboard.c.orig 2008-02-23 15:14:29.000000000 +0100
+++ linux/drivers/char/keyboard.c 2008-02-23 15:20:25.000000000 +0100
@@ -1240,7 +1240,7 @@
}
param.shift = shift_final = (shift_state | kbd->slockstate) ^ kbd->lockstate;
- param.ledstate = getledstate();
+ param.ledstate = kbd->ledflagstate;
key_map = key_maps[shift_final];
if (atomic_notifier_call_chain(&keyboard_notifier_list, KBD_KEYCODE, ¶m) == NOTIFY_STOP || !key_map) {
@@ -1289,6 +1289,7 @@
(*k_handler[type])(vc, keysym & 0xff, !down);
+ param.ledstate = kbd->ledflagstate;
atomic_notifier_call_chain(&keyboard_notifier_list, KBD_POST_KEYSYM, ¶m);
if (type != KT_SLOCK)
reply other threads:[~2008-02-23 14:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080223142455.GH4244@implementation \
--to=samuel.thibault@ens-lyon.org \
--cc=akpm@linux-foundation.org \
--cc=eklhad@comcast.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.