From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/3] t3404: use configured shell instead of /bin/sh
Date: Sat, 23 Feb 2008 17:28:37 -0500
Message-ID: <20080223222837.GA13628@coredump.intra.peff.net>
References: <20080220235944.GA6278@coredump.intra.peff.net> <20080221000044.GB6429@coredump.intra.peff.net> <200802232113.40100.johannes.sixt@telecom.at> <20080223204005.GA12502@coredump.intra.peff.net> <7v1w732y97.fsf@gitster.siamese.dyndns.org> <20080223211219.GA13178@coredump.intra.peff.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Cc: Johannes Sixt <johannes.sixt@telecom.at>, git@vger.kernel.org,
	Whit Armstrong <armstrong.whit@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
X-From: git-owner@vger.kernel.org Sat Feb 23 23:30:06 2008
Return-path: <git-owner@vger.kernel.org>
Envelope-to: gcvg-git-2@gmane.org
Received: from vger.kernel.org ([209.132.176.167])
	by lo.gmane.org with esmtp (Exim 4.50)
	id 1JT2sc-00055D-VY
	for gcvg-git-2@gmane.org; Sat, 23 Feb 2008 23:30:03 +0100
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755238AbYBWW3J (ORCPT <rfc822;gcvg-git-2@m.gmane.org>);
	Sat, 23 Feb 2008 17:29:09 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752797AbYBWW3F
	(ORCPT <rfc822;git-outgoing>); Sat, 23 Feb 2008 17:29:05 -0500
Received: from 66-23-211-5.clients.speedfactory.net ([66.23.211.5]:2274 "EHLO
	peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1756409AbYBWW2k (ORCPT <rfc822;git@vger.kernel.org>);
	Sat, 23 Feb 2008 17:28:40 -0500
Received: (qmail 11465 invoked by uid 111); 23 Feb 2008 22:28:38 -0000
Received: from coredump.intra.peff.net (HELO coredump.intra.peff.net) (10.0.0.2)
    by peff.net (qpsmtpd/0.32) with SMTP; Sat, 23 Feb 2008 17:28:38 -0500
Received: by coredump.intra.peff.net (sSMTP sendmail emulation); Sat, 23 Feb 2008 17:28:37 -0500
Content-Disposition: inline
In-Reply-To: <20080223211219.GA13178@coredump.intra.peff.net>
Sender: git-owner@vger.kernel.org
Precedence: bulk
List-ID: <git.vger.kernel.org>
X-Mailing-List: git@vger.kernel.org
Archived-At: <http://permalink.gmane.org/gmane.comp.version-control.git/74865>

On Sat, Feb 23, 2008 at 04:12:19PM -0500, Jeff King wrote:

> > shell there.  If you used $SHELL not $SHELL_PATH and wrote to
> > fake-editor.sh, you would have noticed that using $SHELL there
> > was wrong as it would have said "#!bash" for you ;-)
> 
> Actually, my $SHELL is "/usr/local/bin/bash" on the box in question.

Hmm. Actually, we just set SHELL_PATH to SHELL in the Makefile. So I
really don't see the point of SHELL_PATH at all, unless there are some
setups where it is already set outside of git.

-Peff