From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kurt Hackel Subject: Re: [PATCH] blktap: qcow2 image format support Date: Sat, 23 Feb 2008 19:12:05 -0800 Message-ID: <20080224031205.GF14510@ca-server1.us.oracle.com> References: <47BD3B07.1040408@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: xen-devel@lists.xensource.com, Kevin Wolf List-Id: xen-devel@lists.xenproject.org Hi, On Thu, Feb 21, 2008 at 10:31:35AM +0000, Keir Fraser wrote: > On 21/2/08 08:49, "Kevin Wolf" wrote: >=20 > > This patch adds support for the qcow2 image format to blktap. It > > consists mostly of qemu code, adapted to the blktap interfaces. > > Snapshots and compressed images are supported. > >=20 > > The qcow2 driver may be used by either specifying tap:qcow2 or by using > > tap:qcow which will detect that you have a version 2 image and will call > > the qcow2 driver. >=20 > Applied. I had to convert lx to PRIx64 in a number of places. >=20 > -- Ekir Don't know if this build breakage has been reported yet: gcc -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=3D2 -fexceptions -fstack-prot= ector --param=3Dssp-buffer-size=3D4 -m32 -march=3Di386 -mtune=3Dgeneric -fa= synchronous-unwind-tables -m32 -march=3Di686 -fno-strict-aliasing -std=3Dgn= u99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-stateme= nt -m32 -march=3Di686 -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-pro= totypes -Wno-unused-value -Wdeclaration-after-statement -m32 -march=3Di686= -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-va= lue -Wdeclaration-after-statement -D__XEN_TOOLS__ -D_LARGEFILE_SOURCE -D_F= ILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mno-tls-dir= ect-seg-refs -m32 -march=3Di686 -fno-strict-aliasing -std=3Dgnu99 -Wall -Ws= trict-prototypes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_T= OOLS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -D_= LARGEFILE64_SOURCE -mno-tls-direct-seg-refs -m32 -march=3Di686 -fno-strict-= aliasing -std=3Dgnu99 -Wall -Wstrict-prototypes -Wno-unused-value -Wdeclara= tion-after-statement -D__XEN_TOOLS__ -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BI= TS=3D64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -mno-tls-direct-seg-refs = -m32 -march=3Di686 -fno-strict-aliasing -std=3Dgnu99 -Wall -Wstrict-prototy= pes -Wno-unused-value -Wdeclaration-after-statement -D__XEN_TOOLS__ -D_LAR= GEFILE_SOURCE -D_FILE_OFFSET_BITS=3D64 -D_LARGEFILE_SOURCE -D_LARGEFILE64_S= OURCE -mno-tls-direct-seg-refs -Werror -Wno-unused -I../../../tools/libxc -= I../../../tools/include -I ../../libaio/src -I.. -I../lib -I../../../tools= /include -I. -I../../xenstore -D_GNU_SOURCE -Wp,-MD,.block-qcow2.o.d -c -o= block-qcow2.o block-qcow2.c cc1: warnings being treated as errors block-qcow2.c: In function 'qcow2_create': block-qcow2.c:1512: warning: ignoring return value of 'write', declared wit= h attribute warn_unused_result block-qcow2.c:1514: warning: ignoring return value of 'write', declared wit= h attribute warn_unused_result block-qcow2.c:1519: warning: ignoring return value of 'write', declared wit= h attribute warn_unused_result block-qcow2.c:1522: warning: ignoring return value of 'write', declared wit= h attribute warn_unused_result block-qcow2.c:1525: warning: ignoring return value of 'write', declared wit= h attribute warn_unused_result block-qcow2.c: In function 'qcow_write_compressed': block-qcow2.c:1554: warning: ignoring return value of 'ftruncate', declared with attribute warn_unused_result make[4]: *** [block-qcow2.o] Error 1 make[4]: Leaving directory `/builddir/build/BUILD/xen-unstable/tools/blktap= /drivers' Need to deal with return value of writes in qcow2_create() and ftruncate in qcow_write_compressed(). Probably need to deal with errno too. Thanks kurt --=20