From: Carlos Corbacho <carlos@strangeworlds.co.uk>
To: linux-acpi@vger.kernel.org
Cc: lenb@kernel.org
Subject: [PATCH 3/4] acer-wmi: Don't warn if mail LED cannot be detected
Date: Sun, 24 Feb 2008 13:34:29 +0000 [thread overview]
Message-ID: <20080224133429.2317.72620.stgit@pacifica> (raw)
In-Reply-To: <20080224133412.2317.5802.stgit@pacifica>
This warning confuses users, who think it is an error. Not detecting the
mail LED simply means it isn't there, so let's not unduly panic users.
Signed-off-by: Carlos Corbacho <carlos@strangeworlds.co.uk>
---
drivers/misc/acer-wmi.c | 6 ++----
1 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/misc/acer-wmi.c b/drivers/misc/acer-wmi.c
index 99beeb8..68b12d6 100644
--- a/drivers/misc/acer-wmi.c
+++ b/drivers/misc/acer-wmi.c
@@ -1071,10 +1071,8 @@ static int __init acer_wmi_init(void)
}
}
- if (wmi_has_guid(AMW0_GUID1)) {
- if (ACPI_FAILURE(AMW0_find_mailled()))
- printk(ACER_ERR "Unable to detect mail LED\n");
- }
+ if (wmi_has_guid(AMW0_GUID1))
+ AMW0_find_mailled();
find_quirks();
next prev parent reply other threads:[~2008-02-24 13:34 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 13:34 [PATCH 0/4] ACPI-WMI patches for 2.6.25-rc3 Carlos Corbacho
2008-02-24 13:34 ` [PATCH 1/4] acer-wmi: Rename mail LED correctly & remove hardcoded colour Carlos Corbacho
2008-03-11 21:59 ` Len Brown
2008-02-24 13:34 ` [PATCH 2/4] acer-wmi: Make device detection error messages more descriptive Carlos Corbacho
2008-03-11 21:57 ` Len Brown
2008-03-11 22:10 ` Carlos Corbacho
2008-02-24 13:34 ` Carlos Corbacho [this message]
2008-03-11 21:59 ` [PATCH 3/4] acer-wmi: Don't warn if mail LED cannot be detected Len Brown
2008-02-24 13:34 ` [PATCH 4/4] ACPI: WMI: Clean up handling of spec violating data blocks Carlos Corbacho
2008-03-11 22:00 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080224133429.2317.72620.stgit@pacifica \
--to=carlos@strangeworlds.co.uk \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.