Re: [PATCH 6/8] ath5k: Fixes for PCI-E cards

[Christoph Hellwig <hch@infradead.org>]

On Sun, Feb 24, 2008 at 06:28:51AM +0200, Nick Kossifidis wrote:
> +	if((srev >= AR5K_SREV_VER_AR2424 && srev <= AR5K_SREV_VER_AR5424) ||
> +	srev >= AR5K_SREV_VER_AR5416) {
> +		ah->ah_pcie = true;
> +	} else {
> +		ah->ah_pcie = false;
> +	}

Sorry for beeing nitpicky. but the indentation/spacing bracing here
seems just too odd :)

This should be something like:

	if ((srev >= AR5K_SREV_VER_AR2424 && srev <= AR5K_SREV_VER_AR5424) ||
	    srev >= AR5K_SREV_VER_AR5416)
		ah->ah_pcie = true;
	else
		ah->ah_pcie = false;

or even better just leave the else clause out because ah has presumably
been zeroed before.