From: "Ahmed S. Darwish" <darwish.07@gmail.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Rusty Russell <rusty@rustcorp.com.au>,
LKML <linux-kernel@vger.kernel.org>,
lguest@ozlabs.org, akpm <akpm@linux-foundation.org>,
Jeremy Fitzhardinge <jeremy@xensource.com>
Subject: Re: [BUG + PATCH/Bugfix] x86/lguest: fix pgdir pmd index calculation
Date: Mon, 25 Feb 2008 02:18:16 +0200 [thread overview]
Message-ID: <20080225001816.GA2933@ubuntu> (raw)
In-Reply-To: <20080224162653.GA30364@ubuntu>
On Sun, Feb 24, 2008 at 06:26:53PM +0200, Ahmed S. Darwish wrote:
> On Sun, Feb 24, 2008 at 05:18:14PM +0100, Ingo Molnar wrote:
>
> > I've picked up your patch into x86.git#testing (until Rusty picks it
> > up), you can track it the following way:
> >
> > http://people.redhat.com/mingo/x86.git/README
> >
> > it has other lguest fixes as well - could you double-check that
> > x86.git#testing works fine for you as-is? (i've just updated the git
> > tree so it includes your fix as well)
> >
>
> Ofcourse. I'll send you the results by GMT night.
>
This thread's main bug no longer appears. There's a new bug though,
but it looks nicer than the original ugly bug!.
The new bug does *not* appear in mainline with the same patch. It's
a panic, but this time on the _guest_ side (which is the same host's
kernel).
[ 0.023996] CPU: Intel(R) Pentium(R) M processor 1500MHz stepping 05
[ 0.023996] Kernel panic - not syncing: Kernel compiled for Pentium+, requires TSC feature!
[ 0.023996] Pid: 0, comm: swapper Not tainted 2.6.25-rc2-00815-g3db3a05 #64
[ 0.024996] [<c011bbc7>] panic+0x47/0x120
[ 0.024996] [<c0101b30>] lguest_power_off+0x0/0x20
[ 0.024996] [<c02a88c5>] check_bugs+0x155/0x170
[ 0.024996] [<c02a2b1f>] start_kernel+0x22f/0x2d0
[ 0.024996] [<c02a2390>] unknown_bootoption+0x0/0x1f0
[ 0.024996] [<c0101450>] lguest_restart+0x0/0x20
[ 0.024996] [<c0101450>] lguest_restart+0x0/0x20
[ 0.024996] [<c02a5e22>] lguest_init+0x282/0x290
[ 0.024996] =======================
I'll track it further in my first free time slot.
It seems lguest is very sensitive to x86 tree changes. Could it be
included in a sort of automatic guest-boot testing, please ?
Thank you,
--
"Better to light a candle, than curse the darkness"
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
next prev parent reply other threads:[~2008-02-25 0:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 15:55 [BUG + PATCH/Bugfix] x86/lguest: fix pgdir pmd index calculation Ahmed S. Darwish
2008-02-24 16:18 ` Ingo Molnar
2008-02-24 16:26 ` Ahmed S. Darwish
2008-02-25 0:18 ` Ahmed S. Darwish [this message]
2008-02-29 0:32 ` Ahmed S. Darwish
2008-02-29 19:58 ` Ingo Molnar
2008-03-04 6:37 ` Rusty Russell
2008-03-04 12:06 ` Rusty Russell
2008-03-04 12:07 ` [PATCH 1/2] x86: If we cannot calibrate the TSC, we panic Rusty Russell
2008-03-04 12:11 ` [PATCH 2/2] lguest: sanitize the clock Rusty Russell
2008-03-04 12:55 ` [BUG + PATCH/Bugfix] x86/lguest: fix pgdir pmd index calculation Rusty Russell
2008-03-04 15:11 ` Ahmed S. Darwish
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080225001816.GA2933@ubuntu \
--to=darwish.07@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=jeremy@xensource.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rusty@rustcorp.com.au \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.