From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mundt Date: Mon, 25 Feb 2008 05:33:13 +0000 Subject: Re: [PATCH] maple: fix device detection Message-Id: <20080225053313.GA27064@renesas.com> List-Id: References: <1203863423.6474.27.camel@localhost.localdomain> <1203889834.6474.35.camel@localhost.localdomain> <1203892373.6299.2.camel@localhost.localdomain> In-Reply-To: <1203892373.6299.2.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Adrian McMenamin Cc: Greg KH , LKML , linux-sh On Sun, Feb 24, 2008 at 10:32:53PM +0000, Adrian McMenamin wrote: > On Sun, 2008-02-24 at 21:50 +0000, Adrian McMenamin wrote: > > On Sun, 2008-02-24 at 14:30 +0000, Adrian McMenamin wrote: > > > The maple bus driver that went into the kernel mainline in > > > September 2007 contained some bugs which were revealed by the > > > update of the kobj code for the current release series. > > > Unfortunately those bugs also helped ensure maple devices were > > > properly detected. This patch (against the current git) now ensures > > > that devices are properly detected again. > > > > > > > Further testing has shown this has introduced another bug, this time > > limiting the effectiveness of subdevice detection. Please ignore this > > while I work on a fix. > > > Sorry for the confusion, in fact there is nothing wrong with this code > (ie it should be applied), the error was in the driver for the Dreamcast > controller (the device, in general, into which the subdevices are > plugged in and out). > > I will post a fix for that. > > Sorry again. > So what exactly is supposed to be applied here? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757887AbYBYFdg (ORCPT ); Mon, 25 Feb 2008 00:33:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752176AbYBYFd1 (ORCPT ); Mon, 25 Feb 2008 00:33:27 -0500 Received: from mail.renesas.com ([202.234.163.13]:42078 "EHLO mail01.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752590AbYBYFd0 (ORCPT ); Mon, 25 Feb 2008 00:33:26 -0500 Date: Mon, 25 Feb 2008 14:33:13 +0900 From: Paul Mundt To: Adrian McMenamin Cc: Greg KH , LKML , linux-sh Subject: Re: [PATCH] maple: fix device detection Message-ID: <20080225053313.GA27064@renesas.com> References: <1203863423.6474.27.camel@localhost.localdomain> <1203889834.6474.35.camel@localhost.localdomain> <1203892373.6299.2.camel@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1203892373.6299.2.camel@localhost.localdomain> User-Agent: Mutt/1.5.16 (2007-06-09) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 24, 2008 at 10:32:53PM +0000, Adrian McMenamin wrote: > On Sun, 2008-02-24 at 21:50 +0000, Adrian McMenamin wrote: > > On Sun, 2008-02-24 at 14:30 +0000, Adrian McMenamin wrote: > > > The maple bus driver that went into the kernel mainline in > > > September 2007 contained some bugs which were revealed by the > > > update of the kobj code for the current release series. > > > Unfortunately those bugs also helped ensure maple devices were > > > properly detected. This patch (against the current git) now ensures > > > that devices are properly detected again. > > > > > > > Further testing has shown this has introduced another bug, this time > > limiting the effectiveness of subdevice detection. Please ignore this > > while I work on a fix. > > > Sorry for the confusion, in fact there is nothing wrong with this code > (ie it should be applied), the error was in the driver for the Dreamcast > controller (the device, in general, into which the subdevices are > plugged in and out). > > I will post a fix for that. > > Sorry again. > So what exactly is supposed to be applied here?