All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyrill Gorcunov <gorcunov@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Sam Ravnborg <sam@ravnborg.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [Q] x86 - boot/header.S
Date: Mon, 25 Feb 2008 11:06:44 +0300	[thread overview]
Message-ID: <20080225080644.GA6744@cvg> (raw)
In-Reply-To: <47C224D8.8070409@zytor.com>

[H. Peter Anvin - Sun, Feb 24, 2008 at 06:15:52PM -0800]
> Cyrill Gorcunov wrote:
>> Hi Peter, Sam,
>> could you take a look on x86/boot/header.S:280 please?
>> # Zero the bss
>> 	movw	$__bss_start, %di
>> 	movw	$_end+3, %cx
>> 	xorl	%eax, %eax
>> 	subw	%di, %cx
>> 	shrw	$2, %cx
>> 	rep; stosl
>> I wonder why is $_end there instead of $__bss_stop?
>> Well, accroding to vmlinux_32.lsd both _end and __bss_stop
>> are the same BUT __bss_stop is more convenient methink.
>> Would it be usefull to change?
>
> x86/boot/header.S goes with x86/boot/setup.ld and no other linker script.
>
> 	-hpa
>

indeed... :( anyway, setup.ld has the definition of __bss_stop too
though in this case __bss_stop is not equal to _end BUT
[__bss_start;__bss_stop] do cover *bss section anyway.

According to Sam's last post it will not be a problem anymore
'cause of memset further usage.

Thanks for comments, Peter.

		- Cyrill -

      reply	other threads:[~2008-02-25  8:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-23  8:20 [Q] x86 - boot/header.S Cyrill Gorcunov
2008-02-23  8:44 ` Yinghai Lu
2008-02-23  9:07   ` Cyrill Gorcunov
2008-02-23  9:18     ` Sam Ravnborg
2008-02-23  9:21       ` Cyrill Gorcunov
2008-02-25  2:17     ` H. Peter Anvin
2008-02-25  2:15 ` H. Peter Anvin
2008-02-25  8:06   ` Cyrill Gorcunov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080225080644.GA6744@cvg \
    --to=gorcunov@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.