From: Paul Jackson <pj@sgi.com>
To: David Rientjes <rientjes@google.com>
Cc: akpm@linux-foundation.org, clameter@sgi.com,
Lee.Schermerhorn@hp.com, ak@suse.de,
linux-kernel@vger.kernel.org
Subject: Re: [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag
Date: Tue, 26 Feb 2008 00:12:29 -0600 [thread overview]
Message-ID: <20080226001229.aea2f3d5.pj@sgi.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0802250016120.12368@chino.kir.corp.google.com>
David wrote:
+static nodemask_t mpol_relative_nodemask(const nodemask_t *orig,
+ const nodemask_t *rel)
+{
+ nodemask_t ret;
+ nodemask_t tmp;
Could you avoid needing the nodemask_t 'ret' on the stack, by passing
in a "nodemask_t *" pointer to where you want the resulting nodemask_t
written, rather than by returning it by value?
static void mpol_relative_nodemask(nodemask_t *ret, const nodemask_t *orig,
const nodemask_t *rel)
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-02-26 6:12 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 15:35 [patch 1/6] mempolicy: convert MPOL constants to enum David Rientjes
2008-02-25 15:35 ` [patch 2/6] mempolicy: support optional mode flags David Rientjes
2008-02-25 15:35 ` [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag David Rientjes
2008-02-25 15:35 ` [patch 4/6] mempolicy: add bitmap_onto() and bitmap_fold() operations David Rientjes
2008-02-25 15:35 ` [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag David Rientjes
2008-02-25 15:35 ` [patch 6/6] mempolicy: update NUMA memory policy documentation David Rientjes
2008-02-26 17:34 ` Paul Jackson
2008-02-26 21:23 ` David Rientjes
2008-02-26 6:12 ` Paul Jackson [this message]
2008-02-26 6:45 ` [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag David Rientjes
2008-02-26 17:44 ` Paul Jackson
2008-02-26 21:17 ` David Rientjes
2008-02-26 21:30 ` Paul Jackson
2008-02-26 21:27 ` Lee Schermerhorn
2008-02-27 1:17 ` David Rientjes
2008-02-27 1:31 ` David Rientjes
2008-02-27 2:30 ` Paul Jackson
2008-02-27 15:37 ` Lee Schermerhorn
2008-02-27 17:09 ` Paul Jackson
2008-02-28 21:08 ` David Rientjes
2008-02-26 5:46 ` [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag Paul Jackson
2008-02-26 6:53 ` David Rientjes
2008-02-26 17:56 ` Paul Jackson
2008-02-26 21:02 ` David Rientjes
2008-02-26 21:32 ` Lee Schermerhorn
2008-02-26 21:54 ` David Rientjes
2008-02-26 22:08 ` Paul Jackson
2008-02-26 21:39 ` Paul Jackson
2008-02-26 3:20 ` [patch 1/6] mempolicy: convert MPOL constants to enum Paul Jackson
2008-02-26 3:35 ` David Rientjes
2008-02-26 4:02 ` Paul Jackson
2008-02-26 4:21 ` David Rientjes
2008-02-26 4:46 ` Paul Jackson
2008-02-27 19:35 ` Christoph Lameter
2008-02-27 19:59 ` David Rientjes
-- strict thread matches above, loose matches on Subject: below --
2008-03-01 0:44 David Rientjes
2008-03-01 0:45 ` [patch 2/6] mempolicy: support optional mode flags David Rientjes
2008-03-01 0:45 ` [patch 3/6] mempolicy: add MPOL_F_STATIC_NODES flag David Rientjes
2008-03-01 0:45 ` [patch 4/6] mempolicy: add bitmap_onto() and bitmap_fold() operations David Rientjes
2008-03-01 0:45 ` [patch 5/6] mempolicy: add MPOL_F_RELATIVE_NODES flag David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226001229.aea2f3d5.pj@sgi.com \
--to=pj@sgi.com \
--cc=Lee.Schermerhorn@hp.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=clameter@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.