From: Ingo Molnar <mingo@elte.hu>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Björn Steinbrink" <B.Steinbrink@gmx.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.24-git: kmap_atomic() WARN_ON()
Date: Tue, 26 Feb 2008 09:39:04 +0100 [thread overview]
Message-ID: <20080226083904.GC9857@elte.hu> (raw)
In-Reply-To: <47C34CEA.7060307@pobox.com>
* Jeff Garzik <jgarzik@pobox.com> wrote:
> + unsigned long flags;
> +
> + local_irq_save(flags);
hm, couldnt we attach the irq disabling to some spinlock, in a natural
way? Explicit flags fiddling is a PITA once we do things like threaded
irq handlers, -rt, etc.
Ingo
next prev parent reply other threads:[~2008-02-26 8:40 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-06 23:58 2.6.24-git: kmap_atomic() WARN_ON() Thomas Gleixner
2008-02-13 22:39 ` Rafael J. Wysocki
2008-02-14 1:13 ` Thomas Gleixner
2008-02-25 19:59 ` Björn Steinbrink
2008-02-25 20:08 ` Jeff Garzik
2008-02-25 20:35 ` Björn Steinbrink
2008-02-25 20:40 ` Andrew Morton
2008-02-25 22:01 ` Thomas Gleixner
2008-02-25 22:17 ` Andrew Morton
2008-02-25 23:19 ` Jeff Garzik
2008-02-26 8:39 ` Ingo Molnar [this message]
2008-02-26 16:32 ` Jeff Garzik
2008-02-26 18:19 ` Andrew Morton
2008-02-26 20:49 ` Ingo Molnar
2008-02-26 21:37 ` Andrew Morton
2008-02-26 22:59 ` Jeff Garzik
2008-02-27 0:02 ` Alan Cox
2008-02-26 23:49 ` Nick Piggin
2008-02-26 8:50 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226083904.GC9857@elte.hu \
--to=mingo@elte.hu \
--cc=B.Steinbrink@gmx.de \
--cc=akpm@linux-foundation.org \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.