From: Ingo Molnar <mingo@elte.hu>
To: Andy Whitcroft <apw@shadowen.org>
Cc: Christoph Hellwig <hch@infradead.org>,
Andrew Morton <akpm@linux-foundation.org>,
Pekka Paalanen <pq@iki.fi>,
linux-kernel@vger.kernel.org,
Arjan van de Ven <arjan@infradead.org>,
Pavel Roskin <proski@gnu.org>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [RFC] mmiotrace full patch, preview 1
Date: Tue, 26 Feb 2008 11:49:48 +0100 [thread overview]
Message-ID: <20080226104948.GA32659@elte.hu> (raw)
In-Reply-To: <20080226102149.GE20322@shadowen.org>
* Andy Whitcroft <apw@shadowen.org> wrote:
> Ok, so that would be the following, work for everyone?
>
> WARNING: mutexes are preferred for single holder semaphores
> #1: FILE: Z95.c:1:
> + DECLARE_MUTEX(&foo);
>
> WARNING: mutexes are preferred for single holder semaphores
> #3: FILE: Z95.c:3:
> + init_MUTEX(&foo);
yeah.
Acked-by: Ingo Molnar <mingo@elte.hu>
also i guess init_MUTEX_LOCKED() should emit a "this should be a
completion" warning.
i guess non-DEFINE_SPINLOCK old-style spinlock definition:
spinlock_t lock = SPIN_LOCK_UNLOCKED;
should emit a 'use DEFINE_SPINLOCK' warning as well?
Ingo
next prev parent reply other threads:[~2008-02-26 10:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 17:03 [RFC] mmiotrace full patch, preview 1 Pekka Paalanen
2008-02-24 17:59 ` Sam Ravnborg
2008-02-25 22:49 ` Andrew Morton
2008-02-25 23:34 ` Christoph Hellwig
2008-02-26 2:42 ` Pavel Roskin
2008-02-26 8:57 ` Andy Whitcroft
2008-02-26 17:10 ` Christoph Hellwig
2008-02-26 10:21 ` Andy Whitcroft
2008-02-26 10:49 ` Ingo Molnar [this message]
2008-02-26 15:20 ` Andy Whitcroft
2008-02-26 20:02 ` Pekka Paalanen
2008-02-26 17:20 ` Jonathan Corbet
2008-02-27 20:28 ` Pekka Paalanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226104948.GA32659@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=arjan@infradead.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pq@iki.fi \
--cc=proski@gnu.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.