From: Stephen Hemminger <shemminger@vyatta.com>
To: Pekka J Enberg <penberg@cs.helsinki.fi>
Cc: romieu@fr.zoreil.com, sorbica@icplus.com.tw, jesse@icplus.com.tw,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [RFC/PATCH] ipg: add jumbo frame support kconfig option
Date: Tue, 26 Feb 2008 12:32:47 -0800 [thread overview]
Message-ID: <20080226123247.2b63bbf0@extreme> (raw)
In-Reply-To: <Pine.LNX.4.64.0802262148270.12999@sbz-30.cs.Helsinki.FI>
> From: Pekka Enberg <penberg@cs.helsinki.fi>
>
> Convert the internal JUMBO_FRAME #ifdef to CONFIG_IP1000_JUMBO_FRAME proper and
> fix compilation errors.
>
> Cc: Francois Romieu <romieu@fr.zoreil.com>
> Cc: Sorbica Shieh <sorbica@icplus.com.tw>
> Cc: Jesse Huang <jesse@icplus.com.tw>
> Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
Please don't do this as a config option. Config options seem like a good idea
to developers but are difficult for distributions. Either support jumbo
frames by default or not at all.
next prev parent reply other threads:[~2008-02-26 20:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 19:49 [RFC/PATCH] ipg: add jumbo frame support kconfig option Pekka J Enberg
2008-02-26 20:32 ` Stephen Hemminger [this message]
2008-02-26 23:08 ` Jeff Garzik
2008-02-27 7:44 ` Pekka J Enberg
2008-02-27 7:52 ` Pekka J Enberg
2008-02-27 8:05 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2008-06-20 6:37 Andrew Savchenko
2008-06-20 11:12 ` Pekka Enberg
2008-06-20 15:41 ` Stephen Hemminger
2008-06-22 9:23 ` Pekka J Enberg
2008-06-22 13:07 ` Andrew Savchenko
2008-06-21 0:04 ` Andrew Savchenko
2008-02-26 19:46 Pekka J Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226123247.2b63bbf0@extreme \
--to=shemminger@vyatta.com \
--cc=jesse@icplus.com.tw \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=romieu@fr.zoreil.com \
--cc=sorbica@icplus.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.