From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
torvalds@osdl.org, "Cai, Crane" <Crane.Cai@amd.com>
Subject: Re: GAK!!!! Re: PCI: AMD SATA IDE mode quirk
Date: Tue, 26 Feb 2008 12:45:06 +0000 [thread overview]
Message-ID: <20080226124506.681dfac9@core> (raw)
In-Reply-To: <47C346E2.10908@garzik.org>
> I agree. I [obviously] missed this when I ack'd, mainly ack'ing the
> overall change.
>
> BIOS certainly may modify that PCI config register, but that's before
> the kernel boots. So, using pdev->class is fine.
I don't think the resume quirk is needed either as the core PCI
save/restore code rewrites the PCI registers so should be rewriting the
class back on resume as well.
prev parent reply other threads:[~2008-02-26 12:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200802220059.m1M0xgjZ022717@hera.kernel.org>
2008-02-22 9:48 ` GAK!!!! Re: PCI: AMD SATA IDE mode quirk Alan Cox
2008-02-22 10:02 ` Alan Cox
2008-02-22 10:34 ` Jiri Slaby
2008-02-25 22:53 ` Jeff Garzik
2008-02-26 2:15 ` Crane Cai
2008-02-26 12:45 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226124506.681dfac9@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=Crane.Cai@amd.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.