From: Jamie Lokier <jamie@shareable.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ide.c make write cacheing controllable by guest
Date: Tue, 26 Feb 2008 12:49:56 +0000 [thread overview]
Message-ID: <20080226124956.GA13669@shareable.org> (raw)
In-Reply-To: <18372.748.889104.623158@mariner.uk.xensource.com>
Ian Jackson wrote:
> > Ideally, the host would provide variation of fdatasync() which flushes
> > data to hard storage in the same way that kernel filesystem journal
> > writes can do, and Qemu would use that.
>
> Another question arises: do we want bdrv_flush to call (eventually)
> fsync or fdatasync ? If the latter we need to make sure that we call
> fsync instead when necessary, for example when a cow file is extended.
I'm imagining that fdatasync() will flush the necessary metadata,
including file size, when a file is extended. As would O_DSYNC.
I could be wrong, but I think it's expected to do that, as I recall
VxFS doing something like that with O_DSYNC.
Then again, even if it's meant to, that doesn't mean it does...
-- Jamie
next prev parent reply other threads:[~2008-02-26 12:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-25 18:13 [Qemu-devel] [PATCH] ide.c make write cacheing controllable by guest Ian Jackson
2008-02-25 20:50 ` Jamie Lokier
2008-02-26 1:16 ` Chris Wedgwood
2008-02-26 7:32 ` Jamie Lokier
2008-02-26 12:15 ` Ian Jackson
2008-02-26 12:49 ` Jamie Lokier [this message]
2008-02-26 16:57 ` Ian Jackson
2008-02-26 17:25 ` Jamie Lokier
2008-02-26 18:11 ` Ian Jackson
-- strict thread matches above, loose matches on Subject: below --
2008-03-27 18:02 Ian Jackson
2008-03-27 18:16 ` Paul Brook
2008-03-28 9:38 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226124956.GA13669@shareable.org \
--to=jamie@shareable.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.