Re: [RFC] Build in clone

[Johan Herland <johan@herland.net>]

On Tuesday 26 February 2008, Johan Herland wrote:
> [1] Verbose output from t5700-clone-reference.sh:
> 
> $ ./t5700-clone-reference.sh --verbose
> * expecting success: test_create_repo A && cd A &&
> echo first > file1 &&
> git add file1 &&
> git commit -m initial
> Created initial commit 8c40535: initial
>  1 files changed, 1 insertions(+), 0 deletions(-)
>  create mode 100644 file1
> *   ok 1: preparing first repository
> 
> * expecting success: git clone A B && cd B &&
> echo second > file2 &&
> git add file2 &&
> git commit -m addition &&
> git repack -a -d &&
> git prune
> Initialize B/.git
> Initialized empty Git repository in B/.git/
> Okay
> Get for /home/johanh/git-test/git/t/trash/A/.git
> 0x714f50
> HEAD
> refs/heads/master
> work tree now /home/johanh/git-test/git/t/trash/B
> Created commit 4f5d964: addition
>  1 files changed, 1 insertions(+), 0 deletions(-)
>  create mode 100644 file2
> Counting objects: 6, done.
> Compressing objects: 100% (3/3), done.
> Writing objects: 100% (6/6), done.
> Total 6 (delta 0), reused 0 (delta 0)
> *   ok 2: preparing second repository
> 
> * expecting success: git clone -l -s --reference B A C
> Initialize C/.git
> Initialized empty Git repository in C/.git/
> Okay
> Wrote /home/johanh/git-test/git/t/trash/B/.git/objects
>  to C/.git/objects/info/alternates
> 4f5d96490c0371a2814efb3203ed699ef4814fda -> C/.git/refs/reference-tmp/4f5d96490c0371a2814efb3203ed699ef4814fda
> error: refs/remotes/origin/HEAD does not point to a valid object!
> error: Z;n�+ does not point to a valid object!
> error: Z;n�+ does not point to a valid object!
> error: �p does not point to a valid object!
> error: Z;n�+ does not point to a valid object!
> error: Z;n�+ does not point to a valid object!
> error: Y;n�+ does not point to a valid object!
> error: q does not point to a valid object!
> ./test-lib.sh: line 193: 32376 Segmentation fault      git clone -l -s --reference B A C
> * FAIL 3: cloning with reference (-l -s)
>         git clone -l -s --reference B A C

Running this test with GDB, I get the following backtrace:

#0  0x0000000000474b87 in is_null_sha1 (sha1=0x100000008 <Address 0x100000008 out of bounds>) at cache.h:464
#1  0x0000000000474ad3 in do_one_ref (base=0x4dc8ff "refs/", fn=0x419471 <setup_tmp_ref>, trim=0, cb_data=0x7498d0, entry=0xffffffff) at refs.c:474
#2  0x0000000000474e28 in do_for_each_ref (base=0x4dc8ff "refs/", fn=0x419471 <setup_tmp_ref>, trim=0, cb_data=0x7498d0) at refs.c:558
#3  0x0000000000474ecd in for_each_ref (fn=0x419471 <setup_tmp_ref>, cb_data=0x7498d0) at refs.c:580
#4  0x0000000000419706 in setup_reference (repo=0x745070 "C/.git") at builtin-clone.c:211
#5  0x0000000000419fce in cmd_clone (argc=2, argv=0x7fff7a282fa0, prefix=0x0) at builtin-clone.c:422
#6  0x0000000000404ba3 in run_command (p=0x6ff710, argc=7, argv=0x7fff7a282fa0) at git.c:248
#7  0x0000000000404d55 in handle_internal_command (argc=7, argv=0x7fff7a282fa0) at git.c:378
#8  0x0000000000404ebe in main (argc=7, argv=0x7fff7a282fa0) at git.c:442

Seems the "loose" ref_list in do_for_each_ref() becomes corrupted.

Will investigate more later.


...Johan

-- 
Johan Herland, <johan@herland.net>
www.herland.net