All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Borislav Petkov <petkovbb@googlemail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org,
	Borislav Petkov <petkovbb@gmail.com>,
	Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
Subject: Re: [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues
Date: Tue, 26 Feb 2008 23:37:29 +0100	[thread overview]
Message-ID: <200802262337.29873.bzolnier@gmail.com> (raw)
In-Reply-To: <1204012194-4208-3-git-send-email-petkovbb@gmail.com>


On Tuesday 26 February 2008, Borislav Petkov wrote:
> Signed-off-by: Borislav Petkov <petkovbb@gmail.com>
> ---
>  drivers/ide/ide-cd.c |  634 +++++++++++++++++++++++++------------------------
>  1 files changed, 323 insertions(+), 311 deletions(-)

With 300 lines changed this is not trivial to review/apply anymore
(yeah, I sound like a broken record ;-) and since I've already applied
Paolo's patch from two days ago this one heavily rejects...

Moreover md5sum is different before/after the patch - I tried really hard
to figure out why (by reverting some changes) but finally I gave up.

Please:
- resync
- factor out changes which affect resulting binary
- resubmit

Thanks,
Bart

  reply	other threads:[~2008-02-26 22:23 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-26  7:49 ide-cd: trivial fixes Borislav Petkov
2008-02-26  7:49 ` Borislav Petkov
2008-02-26  7:49 ` [PATCH] ide-cd: put proc-related functions together under single ifdef Borislav Petkov
2008-02-26  7:49   ` Borislav Petkov
2008-02-26 22:25   ` Bartlomiej Zolnierkiewicz
2008-02-26  7:49 ` [PATCH] ide-cd: fix some codestyle and most of the checkpatch.pl issues Borislav Petkov
2008-02-26  7:49   ` Borislav Petkov
2008-02-26 22:37   ` Bartlomiej Zolnierkiewicz [this message]
2008-02-26 23:16     ` Paolo Ciarrocchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802262337.29873.bzolnier@gmail.com \
    --to=bzolnier@gmail.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paolo.ciarrocchi@gmail.com \
    --cc=petkovbb@gmail.com \
    --cc=petkovbb@googlemail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.