From: Andrew Morton <akpm@linux-foundation.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: fix sparse variable shadowing and int as NULL pointer in rocket.c
Date: Wed, 27 Feb 2008 15:58:36 -0800 [thread overview]
Message-ID: <20080227155836.48d86c12.akpm@linux-foundation.org> (raw)
In-Reply-To: <1204155487.20280.20.camel@brick>
On Wed, 27 Feb 2008 15:38:07 -0800
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> > Probably this code is cleaner than the old version so let's do it, but it
> > seems that we need a general fix.
>
> min3()? No _good_ ideas I'm afraid.
Fix sparse, I'd say. Probably hard to do, but that warning really
isn't useful.
prev parent reply other threads:[~2008-02-27 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 17:46 [PATCH] char: fix sparse variable shadowing and int as NULL pointer in rocket.c Harvey Harrison
2008-02-27 23:29 ` Andrew Morton
2008-02-27 23:38 ` Harvey Harrison
2008-02-27 23:58 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227155836.48d86c12.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.