From: Paul Moore <paul.moore@hp.com>
To: Adrian Bunk <bunk@kernel.org>
Cc: sds@tycho.nsa.gov, jmorris@namei.org, eparis@parisplace.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] selinux/netlabel.c should #include "netlabel.h"
Date: Wed, 27 Feb 2008 16:42:57 -0500 [thread overview]
Message-ID: <200802271642.57556.paul.moore@hp.com> (raw)
In-Reply-To: <20080227212042.GK29269@cs181133002.pp.htv.fi>
On Wednesday 27 February 2008 4:20:42 pm Adrian Bunk wrote:
> Every file should include the headers containing the externs for its
> global code.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
It doesn't _need_ the file in the strictest sense, the header file is
just there for the core SELinux code to call into the NetLabel/SELinux
glue code (what is in security/selinux/netlabel.c). However, if this
is to conform better to kernel coding policy (I assume that is the case
here?) then that is fine with me.
Acked-by: Paul Moore <paul.moore@hp.com>
> ---
> 1f65757bac3e82514b447822ab30ee10d33a59a2 foobar
> diff --git a/security/selinux/netlabel.c
> b/security/selinux/netlabel.c index 0fa2be4..6d22d76 100644
> --- a/security/selinux/netlabel.c
> +++ b/security/selinux/netlabel.c
> @@ -34,6 +34,7 @@
>
> #include "objsec.h"
> #include "security.h"
> +#include "netlabel.h"
>
> /**
> * selinux_netlbl_sidlookup_cached - Cache a SID lookup
--
paul moore
linux security @ hp
next prev parent reply other threads:[~2008-02-27 21:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 21:20 [2.6 patch] selinux/netlabel.c should #include "netlabel.h" Adrian Bunk
2008-02-27 21:42 ` Paul Moore [this message]
2008-02-27 21:55 ` Adrian Bunk
2008-02-27 22:08 ` Paul Moore
2008-02-27 22:16 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802271642.57556.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=bunk@kernel.org \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.