From: Russ Anderson <rja@sgi.com>
To: linux-ia64@vger.kernel.org
Subject: Re: ia64_mca_cpe_int_handler - take 2
Date: Wed, 27 Feb 2008 23:04:44 +0000 [thread overview]
Message-ID: <20080227230444.GA22656@sgi.com> (raw)
In-Reply-To: <47C530E6.7080905@bull.net>
On Wed, Feb 27, 2008 at 10:44:06AM +0100, Zoltan Menyhart wrote:
> /* Get the CPE error record and log it */
> - ia64_mca_log_sal_error_record(SAL_INFO_TYPE_CPE);
> -
> + ia64_mca_log_sal_error_record(SAL_INFO_TYPE_CPE,
> + 1 /* not called from the MCA/INIT handlers */);
Minor nit. Please #define values.
#define MCA_IRQ_NOTSAFE 0 /* called from the MCA/INIT handlers */
#define MCA_IRQ_SAFE 1 /* not called from the MCA/INIT handlers */
ia64_mca_log_sal_error_record(SAL_INFO_TYPE_CPE, MCA_IRQ_SAFE);
Thanks,
--
Russ Anderson, OS RAS/Partitioning Project Lead
SGI - Silicon Graphics Inc rja@sgi.com
prev parent reply other threads:[~2008-02-27 23:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 9:44 ia64_mca_cpe_int_handler - take 2 Zoltan Menyhart
2008-02-27 23:04 ` Russ Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227230444.GA22656@sgi.com \
--to=rja@sgi.com \
--cc=linux-ia64@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.