Re: [PATCH 01/15] memcg: mm_match_cgroup not vm_match_cgroup

[Andrew Morton <akpm@linux-foundation.org>]

On Wed, 27 Feb 2008 23:19:08 -0800 (PST) David Rientjes <rientjes@google.com> wrote:

> On Wed, 27 Feb 2008, Andrew Morton wrote:
> 
> > > -#define vm_match_cgroup(mm, cgroup)	\
> > > +#define mm_match_cgroup(mm, cgroup)	\
> > >  	((cgroup) == rcu_dereference((mm)->mem_cgroup))
> > 
> > Could be written in C, methinks.
> > 
> > Unless we really want to be able to pass a `struct page_cgroup *' in place
> > of arg `mm' here.  If we don't want to be able to do that (prays fervently)
> > then let's sleep happily in the knowledge that the C type system prevents
> > us from doing it accidentally?
> > 
> 
> Writing vm_match_cgroup() as a static inline function in 
> include/linux/memcontrol.h created all the sparc build errors about two 
> weeks ago because of the dependency on linux/mm.h and linux/rcupdate.h.

It's become an faq already?  Should have put a comment in there..

That's the second ugly hack in that file because of missing includes.  It's
preferable to add the needed includes, or just temper our little
inline-everything fetish.  

Oh well.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>