From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JUgUZ-0007j4-BC for mharc-grub-devel@gnu.org; Thu, 28 Feb 2008 05:59:59 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUgUX-0007iu-7K for grub-devel@gnu.org; Thu, 28 Feb 2008 05:59:57 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUgUU-0007if-JW for grub-devel@gnu.org; Thu, 28 Feb 2008 05:59:55 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUgUU-0007ic-CW for grub-devel@gnu.org; Thu, 28 Feb 2008 05:59:54 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JUgUT-0007G3-Tp for grub-devel@gnu.org; Thu, 28 Feb 2008 05:59:54 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JUgUR-0007GD-Kh for grub-devel@gnu.org; Thu, 28 Feb 2008 11:59:53 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JUgSa-0000eL-R2 for grub-devel@gnu.org; Thu, 28 Feb 2008 11:57:56 +0100 Date: Thu, 28 Feb 2008 11:57:56 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080228105756.GA2341@thorin> References: <20080208161855.GA19377@thorin> <200802092103.09542.okuji@enbug.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <200802092103.09542.okuji@enbug.org> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] if timeout is set to zero, don't bother drawing the menu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2008 10:59:57 -0000 On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > On Friday 08 February 2008 17:18, Robert Millan wrote: > > Fixes an ugly result of setting timeout=0. > > > > When this is combined with the "sleep" patch I just sent, user can > > implement hiddenmenu-like functionality via scripting: > > > > echo -n "Press `ESC' to enter the menu... " > > if sleep -v -i 10 ; then > > set timeout=10 > > else > > set timeout=0 > > fi > > I think this is a bit strange. I don't think anybody expects that "sleep" > outputs a counter or is interrupted by a key input. It is too different from > POSIX's sleep. > > My preference is rather to extend "read". Bash's "read" accepts a timeout and > some other options. I started implementing this, and then noticed that it is a bit odd that read prints timeout at the same time it is trying to obtain input from the user. Timeout printing uses gotoxy() and erases current line. Don't you think it'd look annoying? -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)