From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 1/1] ocfs2_net: Debug interface added to o2net
Date: Thu Feb 28 13:22:47 2008 [thread overview]
Message-ID: <20080228212052.GC23975@mail.oracle.com> (raw)
In-Reply-To: <1204081700-29323-2-git-send-email-sunil.mushran@oracle.com>
On Tue, Feb 26, 2008 at 07:08:20PM -0800, Sunil Mushran wrote:
> This patch is a forward port of net_proc.c in OCFS2 1.2. The difference
> here is that the debugging funtionality is exposed via debugfs.
The code looks good and sign-offable, but you need to either
wrap it in CONFIG_DEBUG_FS or make CONFIG_OCFS2 depend on
CONFIG_DEBUG_FS. In fact, I think we have the problem already with
ocfs2_dlm_init_debug().
Joel
--
"When I am working on a problem I never think about beauty. I
only think about how to solve the problem. But when I have finished, if
the solution is not beautiful, I know it is wrong."
- Buckminster Fuller
Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127
next prev parent reply other threads:[~2008-02-28 13:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 19:09 [Ocfs2-devel] Patch to add debugfs interface to o2net Sunil Mushran
2008-02-26 19:09 ` [Ocfs2-devel] [PATCH 1/1] ocfs2_net: Debug interface added " Sunil Mushran
2008-02-28 13:22 ` Joel Becker [this message]
2008-02-28 13:26 ` Mark Fasheh
2008-02-28 17:05 ` Joel Becker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080228212052.GC23975@mail.oracle.com \
--to=joel.becker@oracle.com \
--cc=ocfs2-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.