From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JUrBq-0000du-8t for mharc-grub-devel@gnu.org; Thu, 28 Feb 2008 17:25:22 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JUrBo-0000dE-RS for grub-devel@gnu.org; Thu, 28 Feb 2008 17:25:20 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JUrBo-0000cn-02 for grub-devel@gnu.org; Thu, 28 Feb 2008 17:25:20 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JUrBn-0000ci-Qt for grub-devel@gnu.org; Thu, 28 Feb 2008 17:25:19 -0500 Received: from ns39764.ovh.net ([91.121.25.85] helo=nexedi.com) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JUrBn-0000P4-I9 for grub-devel@gnu.org; Thu, 28 Feb 2008 17:25:19 -0500 Received: from [10.8.0.46] (unknown [10.8.0.46]) by nexedi.com (Postfix) with ESMTP id 7459F3D97C for ; Thu, 28 Feb 2008 23:33:48 +0100 (CET) From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Thu, 28 Feb 2008 23:25:17 +0100 User-Agent: KMail/1.9.4 References: <20080208161855.GA19377@thorin> <200802092103.09542.okuji@enbug.org> <20080228105756.GA2341@thorin> In-Reply-To: <20080228105756.GA2341@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200802282325.17822.okuji@enbug.org> X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] if timeout is set to zero, don't bother drawing the menu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2008 22:25:21 -0000 On Thursday 28 February 2008 11:57, Robert Millan wrote: > On Sat, Feb 09, 2008 at 09:03:09PM +0100, Yoshinori K. Okuji wrote: > > On Friday 08 February 2008 17:18, Robert Millan wrote: > > > Fixes an ugly result of setting timeout=0. > > > > > > When this is combined with the "sleep" patch I just sent, user can > > > implement hiddenmenu-like functionality via scripting: > > > > > > echo -n "Press `ESC' to enter the menu... " > > > if sleep -v -i 10 ; then > > > set timeout=10 > > > else > > > set timeout=0 > > > fi > > > > I think this is a bit strange. I don't think anybody expects that "sleep" > > outputs a counter or is interrupted by a key input. It is too different > > from POSIX's sleep. > > > > My preference is rather to extend "read". Bash's "read" accepts a timeout > > and some other options. > > I started implementing this, and then noticed that it is a bit odd that > read prints timeout at the same time it is trying to obtain input from the > user. > > Timeout printing uses gotoxy() and erases current line. Don't you think > it'd look annoying? Maybe. But we don't care about the character entered by the user in this case, so we could simply disable echoing. Okuji