From: "S.Çağlar Onur" <caglar@pardus.org.tr>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Lee Schermerhorn <Lee.Schermerhorn@hp.com>,
Paul Jackson <pj@sgi.com>,
linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: trivial clean up to zlc_setup
Date: Fri, 29 Feb 2008 15:31:34 +0200 [thread overview]
Message-ID: <200802291531.36498.caglar@pardus.org.tr> (raw)
In-Reply-To: <20080229171136.66F6.KOSAKI.MOTOHIRO@jp.fujitsu.com>
[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]
Hi;
29 Şub 2008 Cum tarihinde, KOSAKI Motohiro şunları yazmıştı:
> > > - if (jiffies - zlc->last_full_zap > 1 * HZ) {
> > > + if (time_after(jiffies, zlc->last_full_zap + HZ)) {
> > > bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST);
> > > zlc->last_full_zap = jiffies;
> > > }
> >
> > That's a mainline bug. Also present in 2.6.24, maybe earlier.
> > But it's a minor one - we'll fix it up one second later (yes?)
>
> I think so, may be.
Andrew "Use time_* macros" series i sent to LKML on 14 Feb [1] has this chunk also (and by the way this version not includes linux/jiffies.h for time_after macro). Some part of this series already gone into Linus's tree with different subsystems but others not received any review/ack or nack. Will you grab others for -mm or will i resend them?
[1] http://lkml.org/lkml/2008/2/14/195
Cheers
--
S.Çağlar Onur <caglar@pardus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/
Linux is like living in a teepee. No Windows, no Gates and an Apache in house!
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-02-29 13:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 6:19 trivial clean up to zlc_setup KOSAKI Motohiro
2008-02-29 6:19 ` KOSAKI Motohiro
2008-02-29 8:05 ` Andrew Morton
2008-02-29 8:05 ` Andrew Morton
2008-02-29 8:30 ` KOSAKI Motohiro
2008-02-29 8:30 ` KOSAKI Motohiro
2008-02-29 13:31 ` S.Çağlar Onur [this message]
2008-02-29 15:36 ` Paul Jackson
2008-02-29 15:36 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200802291531.36498.caglar@pardus.org.tr \
--to=caglar@pardus.org.tr \
--cc=Lee.Schermerhorn@hp.com \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=pj@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.