All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Baker <linux@baker-net.org.uk>
To: linux-wireless@vger.kernel.org, rt2400-devel@lists.sourceforge.net
Cc: "Johannes Berg" <johannes@sipsolutions.net>
Subject: FIF_ filter flags
Date: Fri, 29 Feb 2008 23:39:27 +0000	[thread overview]
Message-ID: <200802292339.27174.linux@baker-net.org.uk> (raw)

Hi,

I've spotted something in the way rt2x00 handles the filter setting flags that 
doesn't seem to match the documentation. I suspect it makes no difference in 
practice but there is a change needed in that area anyway so I'd like to get 
it right in the patch.

The documentation says a driver should clear any flags for data which it can't 
provide but makes no mention of doing anything about unrequested data that it 
does provide. The current rt2x00 implementation will set the relevant flag if 
it can't help providing something that wasn't asked for.

For example rt2x00 devices only have one promiscuous mode that covers traffic 
in the same and other BSSes therefore if either of FIF_PROMISC_IN_BSS or 
FIF_OTHER_BSS are set then the driver will set both of them in the returned 
flags value.

It will also for some devices set the FIF_ALLMULTI flag if mc_count is non 
zero.

If this behaviour is considered desirable then I'll keep it working when 
making the change but if not I'll remove it.

Thanks

Adam

             reply	other threads:[~2008-02-29 23:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-29 23:39 Adam Baker [this message]
2008-03-01  0:09 ` FIF_ filter flags Johannes Berg
2008-03-01 11:55   ` Adam Baker
2008-03-01 12:47     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200802292339.27174.linux@baker-net.org.uk \
    --to=linux@baker-net.org.uk \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rt2400-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.