All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Jean-Luc Herren <jlh@gmx.ch>, Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fast-import: exit with proper message if not a git dir
Date: Sun, 2 Mar 2008 18:16:49 -0500	[thread overview]
Message-ID: <20080302231649.GD8410@spearce.org> (raw)
In-Reply-To: <47C735E2.2010500@gmx.ch>

Jean-Luc Herren <jlh@gmx.ch> wrote:
> git fast-import expects to be run from an existing (possibly
> empty) repository.  It was dying with a suboptimal message if that
> wasn't the case.
> 
> Signed-off-by: Jean-Luc Herren <jlh@gmx.ch>
> ---
> fast-import.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fast-import.c b/fast-import.c
> index 0d3449f..7f197d5 100644
> --- a/fast-import.c
> +++ b/fast-import.c
> @@ -2377,6 +2377,7 @@ int main(int argc, const char **argv)
> {
> 	unsigned int i, show_stats = 1;
> 
> +	setup_git_directory();
> 	git_config(git_pack_config);
> 	if (!pack_compression_seen && core_compression_seen)
> 		pack_compression_level = core_compression_level;

Acked-by: Shawn O. Pearce <spearce@spearce.org>

-- 
Shawn.

      reply	other threads:[~2008-03-02 23:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 22:29 [PATCH] fast-import: exit with proper message if not a git dir Jean-Luc Herren
2008-03-02 23:16 ` Shawn O. Pearce [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080302231649.GD8410@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jlh@gmx.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.