From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1JWHu3-0001L3-1w for mharc-grub-devel@gnu.org; Mon, 03 Mar 2008 16:08:55 -0500 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JWHu2-0001KV-8U for grub-devel@gnu.org; Mon, 03 Mar 2008 16:08:54 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JWHtz-0001IY-U5 for grub-devel@gnu.org; Mon, 03 Mar 2008 16:08:53 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JWHtz-0001IG-JX for grub-devel@gnu.org; Mon, 03 Mar 2008 16:08:51 -0500 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JWHtz-0004Ay-40 for grub-devel@gnu.org; Mon, 03 Mar 2008 16:08:51 -0500 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1JWHtw-0001Mh-8d for grub-devel@gnu.org; Mon, 03 Mar 2008 22:08:49 +0100 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1JWHs8-00061o-Ka for grub-devel@gnu.org; Mon, 03 Mar 2008 22:06:56 +0100 Date: Mon, 3 Mar 2008 22:06:56 +0100 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080303210656.GD22431@thorin> References: <20080224152237.GB25984@thorin> <47C28F0D.7090703@leat.rub.de> <20080225142009.GJ14597@thorin> <47C66239.9020709@leat.rub.de> <20080228101000.GA350@thorin> <47C68CBD.8020601@leat.rub.de> <20080228104156.GJ350@thorin> <47C69F1D.9090405@leat.rub.de> <20080228170738.GB26926@thorin> <47C7C349.6040303@leat.rub.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <47C7C349.6040303@leat.rub.de> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [NEW PATCH] Add option to grub-probe to accept system devices as arguments X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Mar 2008 21:08:54 -0000 On Fri, Feb 29, 2008 at 09:33:13AM +0100, Fabian Greffrath wrote: > >For this one, I think it'd be much better to rework 10_hurd so that code is > >shared, rather than duplicating the whole blurb. > > Yes, we could source out the complete linux/hurd kernel-adding blurbs > into an external shell library that is shared with 10_* and 30_os-prober. > > However, please don't forget these are two different things. 10_* look > on / and /boot, while os-prober looks on all *other* partitions. For 10_linux it isn't that important since the boot parameters are so small, it's 10_hurd that has more reusable stuff (that big blurb). > >Do you plan to do that later? > > Not a concrete plan yet, However, we should first get thinks *working* > before we care about cosmetics, IMHO. ;) In that case maybe it's better to leave Hurd support for later, than duplicating the whole thing. > >Maybe it's better to echo something here, otherwise it gives the impression > >OS FooBar was just detected and properly added. > > Definitely. I'll add a short warning message. > > Furthermore, I am going to modify the script to immediately 'exit 0' > if it turns out it misses the tools required to update the boot menu > (i.e. os-prober, linux-boot-prober, grub-probe (>= 20080228)). These > tests are spread all over the script at the moment. Ok. > PS: Shouldn't 30_os-prober be an upstream feature of os-prober?! Not sure about that. My initial intention was that in general one could plug in scripts from other system components, but often the code in them depends on many update-grub interfaces which makes it likely to break if something is changed. For now only very simple add-ons exist (memtest86, invaders...). But this one will probably end up being more intermangled with other GRUB parts (see that we're already discussing how to reduce code duplication with 10_hurd). I'd suggest putting it in GRUB, at least for now, if that is fine with you. -- Robert Millan I know my rights; I want my phone call! What use is a phone call… if you are unable to speak? (as seen on /.)