From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: benh@kernel.crashing.org
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@atrey.karlin.mff.cuni.cz,
Linux Kernel list <linux-kernel@vger.kernel.org>,
Matthew Wilcox <matthew@wil.cx>
Subject: Re: Weirdness in pci_read_bases()
Date: Mon, 3 Mar 2008 21:29:55 +0000 [thread overview]
Message-ID: <20080303212955.1c0f29c7@core> (raw)
In-Reply-To: <1204576954.21545.10.camel@pasglop>
> The main question regarding 0 in a BAR is do we know of devices that
> consider it as "disabled" and don't operate/decode 0 ? (That would be
> gross and out of spec but who knows...)
In the PC world it never gets tested so it might be wise to be cautious.
> But that can be solved, using something akin to IORESOURCE_UNSET, like
> we do on powerpc, generalizing it, and having an x86-specific quirk set
> it on anything that comes up with resource->start == 0.
And add pci_resource_unassigned() to wrap it nicely. That would
definitely be a good thing as we have confusion right now and it has
turned up in the real world.
Alan
prev parent reply other threads:[~2008-03-03 21:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-29 2:37 Weirdness in pci_read_bases() Benjamin Herrenschmidt
2008-02-29 7:15 ` Grant Grundler
2008-03-03 19:12 ` Jesse Barnes
2008-03-03 20:42 ` Benjamin Herrenschmidt
2008-03-03 20:57 ` Jesse Barnes
2008-03-03 21:02 ` Jesse Barnes
2008-03-03 21:29 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080303212955.1c0f29c7@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=benh@kernel.crashing.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.