All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: hpa@zytor.com, tglx@linutronix.de, linux-kernel@vger.kernel.org,
	roland@redhat.com
Subject: Re: [patch] x86, i387: fix ptrace leakage using init_fpu()
Date: Tue, 4 Mar 2008 09:13:20 +0100	[thread overview]
Message-ID: <20080304081320.GA5689@elte.hu> (raw)
In-Reply-To: <20080303210108.GA28006@linux-os.sc.intel.com>


* Suresh Siddha <suresh.b.siddha@intel.com> wrote:

> This bug is introduced by the recent i387 merge.
> 
> Current usage of unlazy_fpu() in ptrace specific routines is wrong. 
> unlazy_fpu() will not init fpu if the task never used math. So the 
> ptrace calls can expose the parent tasks FPU data in some cases.
> 
> Replace it with the init_fpu() which will init the math state, if the 
> task never used math before.

thanks Suresh, good catch! Applied to x86.git.

	Ingo

      parent reply	other threads:[~2008-03-04  8:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-03 21:01 [patch] x86, i387: fix ptrace leakage using init_fpu() Suresh Siddha
2008-03-03 21:12 ` Roland McGrath
2008-03-04  8:13 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304081320.GA5689@elte.hu \
    --to=mingo@elte.hu \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=roland@redhat.com \
    --cc=suresh.b.siddha@intel.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.