All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pekka Pietikainen <pp@ee.oulu.fi>
To: Pavel Krauz <krauz@cncz.cz>
Cc: netdev@vger.kernel.org
Subject: Re: capturing vlan on 2.6.18
Date: Tue, 4 Mar 2008 13:18:32 +0200	[thread overview]
Message-ID: <20080304111832.GA20494@ee.oulu.fi> (raw)
In-Reply-To: <200802281226.08987.krauz@cncz.cz>

On Thu, Feb 28, 2008 at 12:26:08PM +0100, Pavel Krauz wrote:
> >> Is this a kernel bug or am I supposed to set something?
> > It's an unfortunate side effect of hardware VLAN acceleration. It
> > can't be turned off (apart from patching the driver to not advertise
> > VLAN acceleration support).
> I think that enabling VLAN tags shall be at least kernel run-time or boot time
>  configurable option.
> 
> For a test I have tried to enable VLAN tags in the Broadcom NX2 network driver (drivers/net/bnx2.c)
> and I got the VLAN back. Can you tell me if this is the correct way:
> 
> --- bnx2.c.bak  2008-02-28 11:47:29.000000000 +0100
> +++ bnx2.c      2008-02-28 11:47:43.000000000 +0100
> @@ -2039,6 +2039,7 @@
>  #endif
>         if (dev->flags & IFF_PROMISC) {
>                 /* Promiscuous mode. */
> +               rx_mode |= BNX2_EMAC_RX_MODE_KEEP_VLAN_TAG;
>                 rx_mode |= BNX2_EMAC_RX_MODE_PROMISCUOUS;
>                 sort_mode |= BNX2_RPM_SORT_USER0_PROM_EN;
>         }
> 
Oh, the no VLAN tags with bnx2 is a slightly different matter,
I've used the patch

#ifdef BCM_VLAN
        if (!bp->vlgrp && !(bp->flags & ASF_ENABLE_FLAG))
                rx_mode |= BNX2_EMAC_RX_MODE_KEEP_VLAN_TAG;
#else

->
        if (!bp->vlgrp) // && !(bp->flags & ASF_ENABLE_FLAG))
                rx_mode |= BNX2_EMAC_RX_MODE_KEEP_VLAN_TAG;

Apparently there's a DOS tool that can be used to disable the ASF bit
(It's some enterprise management thing that I haven't ever figured out what
it's even useful for) permanently, 
http://www.broadcom.com/support/ethernet_nic/netxtremeii.php

Since I need lots of ports on my monitoring boxes anyway, I just use
external dual-port e1000's for monitoring and use the on-board bnx2 for
managment. Much easier :-)

  reply	other threads:[~2008-03-04 11:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-28 11:26 capturing vlan on 2.6.18 Pavel Krauz
2008-03-04 11:18 ` Pekka Pietikainen [this message]
2008-03-04 12:09   ` Pavel Krauz
  -- strict thread matches above, loose matches on Subject: below --
2008-02-27 14:17 Pavel Krauz
2008-02-27 20:55 ` Benny Amorsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304111832.GA20494@ee.oulu.fi \
    --to=pp@ee.oulu.fi \
    --cc=krauz@cncz.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.