From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@eu.citrix.com>
Subject: Re: [PATCH] ioemu: improve colordepth negociation
Date: Tue, 4 Mar 2008 11:44:10 +0000
Message-ID: <20080304114410.GC5038@implementation.uk.xensource.com>
References: <20080303173525.GB4923@implementation.uk.xensource.com>
	<18381.13508.634642.12390@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <18381.13508.634642.12390@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Ian Jackson, le Tue 04 Mar 2008 11:38:44 +0000, a écrit :
> Samuel Thibault writes ("[Xen-devel] [PATCH] ioemu: improve colordepth negociation"):
> > +static vga_draw_line_func *vga_draw_line_table[NB_DEPTHS * VGA_DRAW_LINE_NB] = {
> > +    vga_draw_line2_8,
> > +    vga_draw_line2_16,
> > +    vga_draw_line2_16,
> > +    vga_draw_line2_32,
> > +    vga_draw_line2_32,
> ...
> > -static vga_draw_line_func *vga_draw_line_table[NB_DEPTHS * VGA_DRAW_LINE_NB] = {
> > -    vga_draw_line2_8,
> > -    vga_draw_line2_16,
> > -    vga_draw_line2_16,
> > -    vga_draw_line2_32,
> > -    vga_draw_line2_32,
> 
> Could I suggest that it would be a good idea to avoid enormous code
> rearrangements like this in ioemu ?  That's only going to make the
> ongoing merge situation with qemu worse.
> 
> If you were moving this up the file so that you could refer to it
> later, you could provide a forward declaration.

I was wondering about it indeed.  I'll provide another patch.

Samuel