All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] lguest: include function prototypes
Date: Tue, 4 Mar 2008 12:34:13 +1100	[thread overview]
Message-ID: <200803041234.13480.rusty@rustcorp.com.au> (raw)
In-Reply-To: <1202937275.18204.1.camel@brick>

On Thursday 14 February 2008 08:14:35 Harvey Harrison wrote:
> Fix for sparse warning
> arch/x86/lguest/boot.c:939:13: warning: symbol 'lguest_init' was not
> declared. Should it be static?
>
> Added a declaration to asm-x86/lguest.h and moved the extern arrays there
> as well.  As an alternative to including asm/lguest.h directly, an
> include could be put in linux/lguest.h

Hi Harvey,

   Thanks for the patch.  Currently asm/lguest.h is used for the guest/host 
interface definitions, while these are purely in-guest symbols.  The standard 
for these 'used from asm/declared in asm' seems to be to put the declarations 
in the C file directly.

   However, since this has already been applied to Linus' tree, it's fine.

Thanks!
Rusty.

      parent reply	other threads:[~2008-03-04  1:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 21:14 [PATCH] lguest: include function prototypes Harvey Harrison
2008-02-17 14:02 ` Thomas Gleixner
2008-03-04  1:34 ` Rusty Russell [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200803041234.13480.rusty@rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=harvey.harrison@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.