Re: [PATCH] ati_remote2 autorepeat and loadable keymap support

["Ville Syrjälä" <syrjala@sci.fi>]

On Tue, Mar 04, 2008 at 02:20:19PM +0100, Jiri Kosina wrote:
> On Tue, 4 Mar 2008, Ville Syrjälä wrote:
> 
> > > The attached patch reconfigures the ati_remote2 driver to use soft-autorepeat 
> > > functionality and adds support for loadable key maps.
> > Why was this submitted (and even accepted) without cc:ing me?
> 
> I don't seem to see you in MAINTAINERS entry, so that's probably why you 
> didn't receive confirmation when Andrew has put this patch into -mm.

I guess MODULE_AUTHOR() isn't enough then. I'll send a patch for
MAINTAINERS.

> Merging into -mm doesn't mean that the patch is accepted at all, it just 
> exposes it for wider audience for feedback and testing.
> 
> 
> With respect to autorepeat -- I think that the easiest solution would be 
> registering two separate input devices, one for keyboard and one for 
> mouse, and perform the switching in the driver, depending on the type of 
> received events.

Hmm. IIRC I had one USB mouse which also sent repeat events and the
driver didn't seem to filter them out which is why I added checks to
DirectFB's input driver to filter them in user space. Was that a bug
in the usbhid driver or does it depend on the actual hardware? I still
have that mouse so I can re-test the behavior if needed. I guess the
only issue with registering two input devices whould be that user space
might need some way to tell that they are really part of the same
remote.

-- 
Ville Syrjälä
syrjala@sci.fi
http://www.sci.fi/~syrjala/
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html