From: David Brownell <david-b@pacbell.net>
To: Christian Kujau <lists@nerdbynature.de>
Cc: Alan Stern <stern@rowland.harvard.edu>,
LKML <linux-kernel@vger.kernel.org>,
0x0007@gmail.com, USB list <linux-usb@vger.kernel.org>
Subject: Re: WARNING: at drivers/usb/host/ehci-hcd.c:287
Date: Tue, 4 Mar 2008 16:30:11 -0800 [thread overview]
Message-ID: <200803041630.11832.david-b@pacbell.net> (raw)
In-Reply-To: <alpine.DEB.1.00.0803050012090.5974@sheep.housecafe.de>
On Tuesday 04 March 2008, Christian Kujau wrote:
> On Tue, 4 Mar 2008, David Brownell wrote:
> >>> Or bettter yet, just removing it entirely. ISTR doing that in some
> >>> patches I've not yet sent for merging, and expect that's what my
> >>> preferred fix will be ...
> >>
> >> But removing the WARN_ON won't fix the problem.
> >
> > It fully resolves the $SUBJECT problem. :)
>
> ...and if it's a safe thing to do, I'm happy with it. I really have no
> clue why shutting up a WARN_ON has no (future) implications but if you
> say so I trust you :)
Carrying that WARN_ON forward was inappropriate, so
removing it is a safe thing to do.
There are other lurking issues though.
- Dave
next prev parent reply other threads:[~2008-03-05 0:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-03 0:05 WARNING: at drivers/usb/host/ehci-hcd.c:287 Christian Kujau
2008-03-03 22:38 ` Christian Kujau
2008-03-04 16:29 ` Alan Stern
2008-03-04 18:53 ` Christian Kujau
2008-03-04 20:27 ` Alan Stern
2008-03-04 20:51 ` David Brownell
2008-03-04 20:57 ` Alan Stern
2008-03-04 22:01 ` David Brownell
2008-03-04 23:15 ` Christian Kujau
2008-03-05 0:30 ` David Brownell [this message]
2008-03-05 1:15 ` Christian Kujau
2008-03-05 4:25 ` David Brownell
2008-03-05 22:59 ` Christian Kujau
2008-03-07 19:51 ` Christian Kujau
2008-03-04 7:49 ` Andrew Morton
2008-03-04 8:01 ` Christian Kujau
2008-03-04 8:10 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803041630.11832.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=0x0007@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lists@nerdbynature.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.