From: Alexander van Heukelum <heukelum@mailshack.com>
To: Jeremy Fitzhardinge <jeremy@goop.org>, Ingo Molnar <mingo@elte.hu>
Cc: Alexander van Heukelum <heukelum@fastmail.fm>,
Mark McLoughlin <markmc@redhat.com>,
Ian Campbell <ijc@hellion.org.uk>,
"H. Peter Anvin" <hpa@zytor.com>, Andi Kleen <ak@suse.de>,
Thomas Gleixner <tglx@linutronix.de>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] reserve end-of-conventional-memory to 1MB, 64-bit, use paravirt_enabled
Date: Tue, 4 Mar 2008 20:12:28 +0100 [thread overview]
Message-ID: <20080304191228.GA12403@mailshack.com> (raw)
In-Reply-To: <20080304185742.GA12193@mailshack.com>
Jeremy Fitzhardinge pointed out that looking at the boot_params
struct to determine if the system is running in a paravirtual
environment is not reliable for the Xen case, currently. He also
points out that there already exists a function to determine if
the system is running in a paravirtual environment. So let's use
that instead. This gets rid of the preprocessor test too.
Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
---
Same, for 64 bit.
Greetings,
Alexander
diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
index 269a6b4..48be76c 100644
--- a/arch/x86/kernel/head64.c
+++ b/arch/x86/kernel/head64.c
@@ -72,12 +72,8 @@ static void __init reserve_ebda_region(void)
/* that area is absent. We'll just have to assume */
/* that the paravirt case can handle memory setup */
/* correctly, without our help. */
-#ifdef CONFIG_PARAVIRT
- if ((boot_params.hdr.version >= 0x207) &&
- (boot_params.hdr.hardware_subarch != 0)) {
+ if (paravirt_enabled())
return;
- }
-#endif
/* end of low (conventional) memory */
lowmem = *(unsigned short *)__va(BIOS_LOWMEM_KILOBYTES);
next prev parent reply other threads:[~2008-03-04 19:14 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-24 17:46 [PATCH] Fix alignment of early reservation for EBDA Alexander van Heukelum
2008-02-24 19:27 ` Andi Kleen
2008-02-24 19:41 ` Ingo Molnar
2008-02-24 20:53 ` Alexander van Heukelum
2008-02-25 2:18 ` H. Peter Anvin
2008-02-25 16:54 ` Alexander van Heukelum
2008-02-25 17:01 ` Ingo Molnar
2008-02-25 18:07 ` [PATCH] reserve_early end-of-conventional-memory to 1MB Alexander van Heukelum
2008-02-25 18:13 ` H. Peter Anvin
2008-02-25 19:46 ` Alexander van Heukelum
2008-02-25 21:17 ` H. Peter Anvin
2008-02-26 9:30 ` Ingo Molnar
2008-02-27 14:26 ` Andi Kleen
2008-02-27 14:38 ` [PATCH] reserve_early end-of-conventional-memory to 1MB II - some numbers to put it into perspective Andi Kleen
2008-02-27 16:44 ` H. Peter Anvin
2008-02-27 20:01 ` Alexander van Heukelum
2008-02-28 13:13 ` [PATCH] reserve end-of-conventional-memory to 1MB on 32-bit Alexander van Heukelum
2008-02-28 13:28 ` [RFC] use realmode code to reserve end-of-conventional-memory to 1MB Alexander van Heukelum
2008-02-28 21:12 ` Ian Campbell
2008-02-28 21:14 ` H. Peter Anvin
2008-02-28 23:16 ` Ian Campbell
2008-02-29 20:00 ` Ingo Molnar
2008-03-04 11:41 ` Mark McLoughlin
2008-03-04 14:33 ` Ingo Molnar
2008-03-04 15:12 ` Ian Campbell
2008-03-04 15:13 ` Jeremy Fitzhardinge
2008-03-04 15:25 ` Ingo Molnar
2008-03-04 16:02 ` Jeremy Fitzhardinge
2008-03-04 16:15 ` Ingo Molnar
2008-03-04 16:15 ` Mark McLoughlin
2008-03-04 16:23 ` Ingo Molnar
2008-03-04 17:44 ` Jeremy Fitzhardinge
2008-03-05 15:59 ` Eduardo Habkost
2008-03-05 16:08 ` H. Peter Anvin
2008-03-05 16:53 ` Eduardo Habkost
2008-03-05 17:28 ` H. Peter Anvin
2008-03-05 17:28 ` Jeremy Fitzhardinge
2008-03-05 17:38 ` H. Peter Anvin
2008-03-05 16:38 ` Jeremy Fitzhardinge
2008-03-05 17:27 ` H. Peter Anvin
2008-02-28 21:09 ` [PATCH] reserve end-of-conventional-memory to 1MB on 32-bit Ian Campbell
2008-02-29 11:49 ` Alexander van Heukelum
2008-02-29 17:14 ` Mark McLoughlin
2008-02-29 18:38 ` Alexander van Heukelum
2008-02-29 18:44 ` H. Peter Anvin
2008-02-29 18:56 ` Alexander van Heukelum
2008-02-29 22:06 ` Mark McLoughlin
2008-02-29 22:26 ` Alexander van Heukelum
2008-03-01 16:09 ` [PATCH] reserve end-of-conventional-memory to 1MB on 32-bit v2 Alexander van Heukelum
2008-03-01 16:12 ` [PATCH] reserve end-of-conventional-memory to 1MB on 64-bit add-on Alexander van Heukelum
2008-03-04 11:44 ` [PATCH] reserve end-of-conventional-memory to 1MB on 32-bit v2 Mark McLoughlin
2008-03-04 13:31 ` Alexander van Heukelum
2008-03-04 14:49 ` Ingo Molnar
2008-03-04 15:16 ` Mark McLoughlin
2008-03-04 15:24 ` Ingo Molnar
2008-03-04 15:18 ` Jeremy Fitzhardinge
2008-03-04 16:51 ` Alexander van Heukelum
2008-03-04 17:05 ` H. Peter Anvin
2008-03-04 17:11 ` Jeremy Fitzhardinge
2008-03-04 18:57 ` [PATCH] reserve end-of-conventional-memory to 1MB, 32-bit, use paravirt_enabled Alexander van Heukelum
2008-03-04 19:12 ` Alexander van Heukelum [this message]
2008-02-27 14:25 ` [PATCH] Fix alignment of early reservation for EBDA Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080304191228.GA12403@mailshack.com \
--to=heukelum@mailshack.com \
--cc=ak@suse.de \
--cc=heukelum@fastmail.fm \
--cc=hpa@zytor.com \
--cc=ijc@hellion.org.uk \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markmc@redhat.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.