All of lore.kernel.org
 help / color / mirror / Atom feed
From: wysochanski@sourceware.org <wysochanski@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2/test t-vgsplit-operation.sh
Date: 4 Mar 2008 22:49:00 -0000	[thread overview]
Message-ID: <20080304224900.20503.qmail@sourceware.org> (raw)

CVSROOT:	/cvs/lvm2
Module name:	LVM2
Changes by:	wysochanski at sourceware.org	2008-03-04 22:49:00

Modified files:
	test           : t-vgsplit-operation.sh 

Log message:
	Update vgsplit tests.
	- Add validation on pv_count, lv_count, and snap_count after split
	NOTE: Some of these counts are misleading.  If you compare "lvs" output
	with these counts you will be left scratching your head what a "logical volume"
	really is.  ;-)

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/test/t-vgsplit-operation.sh.diff?cvsroot=lvm2&r1=1.11&r2=1.12

--- LVM2/test/t-vgsplit-operation.sh	2008/03/04 19:48:32	1.11
+++ LVM2/test/t-vgsplit-operation.sh	2008/03/04 22:49:00	1.12
@@ -23,6 +23,18 @@
   rm -f "$f1" "$f2" "$f3" "$f4"
 }
 
+validate_vg_pvlv_counts_()
+{
+	local local_vg=$1
+	local num_pvs=$2
+	local num_lvs=$3
+	local num_snaps=$4
+
+	check_vg_field_ $local_vg pv_count $num_pvs &&
+	check_vg_field_ $local_vg lv_count $num_lvs &&
+	check_vg_field_ $local_vg snap_count $num_snaps
+}
+
 # FIXME: paramaterize lvm1 vs lvm2 metadata; most of these tests should run
 # fine with lvm1 metadata as well; for now, just add disks 5 and 6 as lvm1
 # metadata
@@ -46,6 +58,8 @@
    lvcreate -l 4 -n $lv1 $vg1 $d1 &&
    vgchange -an $vg1 &&
    vgsplit $vg1 $vg2 $d1 &&
+   validate_vg_pvlv_counts_ $vg1 1 0 0 &&
+   validate_vg_pvlv_counts_ $vg2 3 1 0 &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2 &&
    vgremove -f $vg1'
@@ -57,6 +71,7 @@
    lvcreate -l 4 -i 2 -n $lv1 $vg1 $d1 $d2 &&
    vgchange -an $vg1 &&
    vgsplit $vg1 $vg2 $d1 $d2 &&
+   validate_vg_pvlv_counts_ $vg2 4 1 0 &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2'
 
@@ -68,6 +83,7 @@
    lvcreate -l 4 -i 2 -s -n $lv2 $vg1/$lv1 &&
    vgchange -an $vg1 &&
    vgsplit $vg1 $vg2 $d1 $d2 &&
+   validate_vg_pvlv_counts_ $vg2 4 1 1 &&
    lvremove -f $vg2/$lv2 &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2'
@@ -79,6 +95,7 @@
    lvcreate -l 64 -m1 -n $lv1 $vg1 $d1 $d2 $d3 &&
    vgchange -an $vg1 &&
    vgsplit $vg1 $vg2 $d1 $d2 $d3 &&
+   validate_vg_pvlv_counts_ $vg2 4 4 0 &&
    lvremove -f $vg2/$lv1 &&
    vgremove -f $vg2'
 



             reply	other threads:[~2008-03-04 22:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 22:49 wysochanski [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-03-29 16:40 LVM2/test t-vgsplit-operation.sh mornfall
2008-09-30 18:29 mornfall
2008-09-30 17:56 mornfall
2008-04-10 18:55 wysochanski
2008-04-09 21:10 wysochanski
2008-03-21 21:14 wysochanski
2008-02-29  0:09 wysochanski
2008-02-28 17:39 wysochanski
2008-02-28 16:48 wysochanski
2008-01-22  3:30 wysochanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304224900.20503.qmail@sourceware.org \
    --to=wysochanski@sourceware.org \
    --cc=lvm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.