All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@sous-sol.org>
To: "David P. Quigley" <dpquigl@tycho.nsa.gov>
Cc: sds@tycho.nsa.gov, jmorris@namei.org, chrisw@sous-sol.org,
	casey@schaufler-ca.com, linux-security-module@vger.kernel.org,
	selinux@tycho.nsa.gov
Subject: Re: [PATCH 1/1] LSM/SELinux: {get,set}context hooks to access LSM security context information.
Date: Tue, 4 Mar 2008 15:26:08 -0800	[thread overview]
Message-ID: <20080304232608.GD4416@sequoia.sous-sol.org> (raw)
In-Reply-To: <1204667623-16224-1-git-send-email-dpquigl@tycho.nsa.gov>

* David P. Quigley (dpquigl@tycho.nsa.gov) wrote:
> +/* Flags for setcontext */
> +#define LSM_SETCORE	1
> +#define LSM_SETDISK	2
> +
>  #ifdef CONFIG_SECURITY
>  
>  /**
> @@ -1395,6 +1399,9 @@ struct security_operations {
>  	int (*secctx_to_secid)(char *secdata, u32 seclen, u32 *secid);
>  	void (*release_secctx)(char *secdata, u32 seclen);
>  
> +	int (*setcontext)(struct dentry *dentry, void *ctx, u32 ctxlen, int flags);
> +	int (*getcontext)(struct dentry *dentry, void **ctx, u32 *ctxlen);

Is this meant to address Casey's argument about the mac label hook name?
Also, why have you made the distinction of in-core vs. on disk in the
interface?  As I mentioned, I think just needs a little better
description of why.

thanks,
-chris

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

  parent reply	other threads:[~2008-03-04 23:26 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 21:53 [PATCH 1/1] LSM/SELinux: {get,set}context hooks to access LSM security context information David P. Quigley
2008-03-04 22:21 ` Dave Quigley
2008-03-04 23:26 ` Chris Wright [this message]
2008-03-04 23:07   ` Dave Quigley
2008-03-04 23:52     ` Chris Wright
2008-03-04 23:35       ` Dave Quigley
2008-03-05  0:10         ` Chris Wright
2008-03-04 23:59           ` Dave Quigley
2008-03-05  0:31             ` James Morris
2008-03-05  1:39             ` Chris Wright
2008-03-04 23:48 ` James Morris
2008-03-04 23:26   ` Dave Quigley
  -- strict thread matches above, loose matches on Subject: below --
2008-03-04 22:53 Casey Schaufler
2008-03-04 22:33 ` Dave Quigley
2008-03-04 23:14   ` Chris Wright
2008-03-04 22:51     ` Dave Quigley
2008-03-04 22:59       ` Dave Quigley
2008-03-05  1:08 Casey Schaufler
2008-03-05 13:41 ` Dave Quigley
2008-03-05 14:08 ` Stephen Smalley
2008-03-05 17:24   ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080304232608.GD4416@sequoia.sous-sol.org \
    --to=chrisw@sous-sol.org \
    --cc=casey@schaufler-ca.com \
    --cc=dpquigl@tycho.nsa.gov \
    --cc=jmorris@namei.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.