All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: linux-kernel@vger.kernel.org, linux-s390@vger.kernel.org
Cc: Hongjie Yang <hongjie@us.ibm.com>,
	Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: [patch 10/10] incorrect reipl nss name.
Date: Wed, 05 Mar 2008 12:54:42 +0100	[thread overview]
Message-ID: <20080305115715.207905001@de.ibm.com> (raw)
In-Reply-To: 20080305115432.691030908@de.ibm.com

[-- Attachment #1: 010-nssname.diff --]
[-- Type: text/plain, Size: 1148 bytes --]

From: Hongjie Yang <hongjie@us.ibm.com>

/sys/firmware/reipl/nss/name contains the nss name when defsys or
savesys command has been executed. If the defsys or savesys command
fails the kernel_nss_name has to be cleared since a reipl on that
nss name won't be possible.

Signed-off-by: Hongjie Yang <hongjie@us.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
---

 arch/s390/kernel/early.c |    8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Index: quilt-2.6/arch/s390/kernel/early.c
===================================================================
--- quilt-2.6.orig/arch/s390/kernel/early.c
+++ quilt-2.6/arch/s390/kernel/early.c
@@ -88,13 +88,17 @@ static noinline __init void create_kerne
 
 	__cpcmd(defsys_cmd, NULL, 0, &response);
 
-	if (response != 0)
+	if (response != 0) {
+		kernel_nss_name[0] = '\0';
 		return;
+	}
 
 	__cpcmd(savesys_cmd, NULL, 0, &response);
 
-	if (response != strlen(savesys_cmd))
+	if (response != strlen(savesys_cmd)) {
+		kernel_nss_name[0] = '\0';
 		return;
+	}
 
 	ipl_flags = IPL_NSS_VALID;
 }

-- 
blue skies,
   Martin.

"Reality continues to ruin my life." - Calvin.

      parent reply	other threads:[~2008-03-05 11:54 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-05 11:54 [patch 00/10] s390 bux fixes for 2.6.25-rc4 Martin Schwidefsky
2008-03-05 11:54 ` [patch 01/10] Update default configuration Martin Schwidefsky
2008-03-05 11:54 ` [patch 02/10] idle: Fix machine check handling in idle loop Martin Schwidefsky
2008-03-05 11:54 ` [patch 03/10] Get rid of memcpy gcc warning workaround Martin Schwidefsky
2008-03-05 11:54 ` [patch 04/10] dasd: let dasd erp matching recognize alias recovery Martin Schwidefsky
2008-03-05 11:54 ` [patch 05/10] dasd: fix reference counting in display method for proc/dasd/devices Martin Schwidefsky
2008-03-05 11:54 ` [patch 06/10] sclp_vt220: speed up console output for interactive work Martin Schwidefsky
2008-03-05 11:54 ` [patch 07/10] zcrypt: fix ap_device_list handling Martin Schwidefsky
2008-03-05 11:54 ` [patch 08/10] Fix IPL from NSS Martin Schwidefsky
2008-03-05 11:54 ` [patch 09/10] Load disabled wait psw if reipl fails Martin Schwidefsky
2008-03-05 11:54 ` Martin Schwidefsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080305115715.207905001@de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=hongjie@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.