All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Becker <Joel.Becker@oracle.com>
To: ocfs2-devel@oss.oracle.com
Subject: [Ocfs2-devel] [PATCH 09/12] ocfs2/dlm: Dumps the purgelist into a debugfs file
Date: Wed Mar  5 11:09:55 2008	[thread overview]
Message-ID: <20080305190949.GH799@ca-server1.us.oracle.com> (raw)
In-Reply-To: <1204678200-26237-10-git-send-email-sunil.mushran@oracle.com>

On Tue, Mar 04, 2008 at 04:49:57PM -0800, Sunil Mushran wrote:
> This patch dumps all the lockres' on the purgelist it can fit in one page
> into a debugfs file. Useful for debugging.
> 
> Signed-off-by: Sunil Mushran <sunil.mushran@oracle.com>
Signed-off-by: Joel Becker <joel.becker@oracle.com>

> ---
>  fs/ocfs2/dlm/dlmdebug.c |   71 +++++++++++++++++++++++++++++++++++++++++++++++
>  fs/ocfs2/dlm/dlmdebug.h |    1 +
>  2 files changed, 72 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
> index f792af5..0842e1b 100644
> --- a/fs/ocfs2/dlm/dlmdebug.c
> +++ b/fs/ocfs2/dlm/dlmdebug.c
> @@ -302,6 +302,7 @@ static int stringify_lockname(const char *lockname, int locklen,
>  #define DLM_DEBUGFS_DLM_STATE			"dlm_state"
>  #define DLM_DEBUGFS_LOCKING_STATE		"locking_state"
>  #define DLM_DEBUGFS_MLE_STATE			"mle_state"
> +#define DLM_DEBUGFS_PURGE_LIST			"purge_list"
>  
>  #ifdef CONFIG_DEBUG_FS
>  /* begin - utils funcs */
> @@ -396,6 +397,63 @@ static int debug_buffer_release(struct inode *inode, struct file *file)
>  }
>  /* end - util funcs */
>  
> +/* begin - purge list funcs */
> +static int debug_purgelist_print(struct dlm_ctxt *dlm, struct debug_buffer *db)
> +{
> +	struct dlm_lock_resource *res;
> +	int out = 0;
> +	unsigned long total = 0;
> +
> +	out += snprintf(db->buf + out, db->len - out,
> +			"Dumping Purgelist for Domain: %s\n", dlm->name);
> +
> +	spin_lock(&dlm->spinlock);
> +	list_for_each_entry(res, &dlm->purge_list, purge) {
> +		++total;
> +		if (db->len - out < 100)
> +			continue;
> +		spin_lock(&res->spinlock);
> +		out += stringify_lockname(res->lockname.name,
> +					  res->lockname.len,
> +					  db->buf + out, db->len - out);
> +		out += snprintf(db->buf + out, db->len - out, "\t%ld\n",
> +				(jiffies - res->last_used)/HZ);
> +		spin_unlock(&res->spinlock);
> +	}
> +	spin_unlock(&dlm->spinlock);
> +
> +	out += snprintf(db->buf + out, db->len - out,
> +			"Total on list: %ld\n", total);
> +
> +	return out;
> +}
> +
> +static int debug_purgelist_open(struct inode *inode, struct file *file)
> +{
> +	struct dlm_ctxt *dlm = inode->i_private;
> +	struct debug_buffer *db;
> +
> +	db = debug_buffer_allocate();
> +	if (!db)
> +		goto bail;
> +
> +	db->len = debug_purgelist_print(dlm, db);
> +
> +	file->private_data = db;
> +
> +	return 0;
> +bail:
> +	return -ENOMEM;
> +}
> +
> +static struct file_operations debug_purgelist_fops = {
> +	.open =		debug_purgelist_open,
> +	.release =	debug_buffer_release,
> +	.read =		debug_buffer_read,
> +	.llseek =	debug_buffer_llseek,
> +};
> +/* end - purge list funcs */
> +
>  /* begin - debug mle funcs */
>  static int dump_mle(struct dlm_master_list_entry *mle, char *buf, int len)
>  {
> @@ -909,6 +967,17 @@ int dlm_debug_init(struct dlm_ctxt *dlm)
>  		goto bail;
>  	}
>  
> +	/* for dumping lockres on the purge list */
> +	dc->debug_purgelist_dentry =
> +			debugfs_create_file(DLM_DEBUGFS_PURGE_LIST,
> +					    S_IFREG|S_IRUSR,
> +					    dlm->dlm_debugfs_subroot,
> +					    dlm, &debug_purgelist_fops);
> +	if (!dc->debug_purgelist_dentry) {
> +		mlog_errno(-ENOMEM);
> +		goto bail;
> +	}
> +
>  	dlm_debug_get(dc);
>  	return 0;
>  
> @@ -925,6 +994,8 @@ void dlm_debug_shutdown(struct dlm_ctxt *dlm)
>  	struct dlm_debug_ctxt *dc = dlm->dlm_debug_ctxt;
>  
>  	if (dc) {
> +		if (dc->debug_purgelist_dentry)
> +			debugfs_remove(dc->debug_purgelist_dentry);
>  		if (dc->debug_mle_dentry)
>  			debugfs_remove(dc->debug_mle_dentry);
>  		if (dc->debug_lockres_dentry)
> diff --git a/fs/ocfs2/dlm/dlmdebug.h b/fs/ocfs2/dlm/dlmdebug.h
> index 313af2a..974a6be 100644
> --- a/fs/ocfs2/dlm/dlmdebug.h
> +++ b/fs/ocfs2/dlm/dlmdebug.h
> @@ -30,6 +30,7 @@ struct dlm_debug_ctxt {
>  	struct dentry *debug_state_dentry;
>  	struct dentry *debug_lockres_dentry;
>  	struct dentry *debug_mle_dentry;
> +	struct dentry *debug_purgelist_dentry;
>  };
>  
>  struct debug_buffer {
> -- 
> 1.5.3.6
> 
> 
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel@oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel

-- 

"In the beginning, the universe was created. This has made a lot 
 of people very angry, and is generally considered to have been a 
 bad move."
        - Douglas Adams

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker@oracle.com
Phone: (650) 506-8127

  reply	other threads:[~2008-03-05 11:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-04 16:50 [Ocfs2-devel] New dlm debug infrastructure - 2nd attempt Sunil Mushran
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 11/12] ocfs2/dlm: Move dlm_print_one_mle() from dlmmaster.c to dlmdebug.c Sunil Mushran
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 09/12] ocfs2/dlm: Dumps the purgelist into a debugfs file Sunil Mushran
2008-03-05 11:09   ` Joel Becker [this message]
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 02/12] ocfs2/dlm: Creates slabcaches for lock and lockres Sunil Mushran
2008-03-05 10:53   ` Joel Becker
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 08/12] ocfs2/dlm: Dumps the mles into a debugfs file Sunil Mushran
2008-03-05 11:09   ` Joel Becker
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 05/12] ocfs2/dlm: Dump the dlm state in " Sunil Mushran
2008-03-05 11:05   ` Joel Becker
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 04/12] ocfs2/dlm: Create debugfs dirs Sunil Mushran
2008-03-05 10:55   ` Joel Becker
2008-03-05 11:05     ` Joel Becker
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 10/12] ocfs2/dlm: Dumps the workqueue into a debugfs file Sunil Mushran
2008-03-05 11:12   ` Joel Becker
2008-03-05 11:22     ` Sunil Mushran
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 07/12] ocfs2/dlm: Move struct dlm_master_list_entry to dlmcommon.h Sunil Mushran
2008-03-05 11:08   ` Joel Becker
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 01/12] ocfs2/dlm: Rename slabcache dlm_mle_cache to o2dlm_mle Sunil Mushran
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 03/12] ocfs2/dlm: Link all lockres' to a tracking list Sunil Mushran
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 06/12] ocfs2/dlm: Dumps the lockres' into a debugfs file Sunil Mushran
2008-03-05 11:07   ` Joel Becker
2008-03-04 16:50 ` [Ocfs2-devel] [PATCH 12/12] ocfs2/dlm: Fix lockname in lockres print function Sunil Mushran
2008-03-05 11:13   ` Joel Becker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080305190949.GH799@ca-server1.us.oracle.com \
    --to=joel.becker@oracle.com \
    --cc=ocfs2-devel@oss.oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.