From: David Chinner <dgc@sgi.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs@oss.sgi.com
Subject: Re: TAKE 977545 - xfsaild causing too many wakeups
Date: Thu, 6 Mar 2008 08:00:35 +1100 [thread overview]
Message-ID: <20080305210035.GA155407@sgi.com> (raw)
In-Reply-To: <47CF05E5.90409@sandeen.net>
On Wed, Mar 05, 2008 at 02:43:17PM -0600, Eric Sandeen wrote:
> David Chinner wrote:
> > xfsaild causing too many wakeups
> >
> > Idle state is not being detected properly by the xfsaild push code.
> > The current idle state is detected by an empty list which may never
> > happen with mostly idle filesystem or one using lazy superblock
> > counters. A single dirty item in the list that exists beyond the
> > push target can result repeated looping attempting to push
> > up to the target because it fails to check if the push target
> > has been acheived or not.
> >
> > Fix by considering a dirty list with everything past the target
> > as an idle state and set the timeout appropriately.
>
> Will this go to 2.6.25?
Yes, it certainly should.
Cheers,
Dave.
--
Dave Chinner
Principal Engineer
SGI Australian Software Group
prev parent reply other threads:[~2008-03-05 21:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-22 4:15 TAKE 977545 - xfsaild causing too many wakeups David Chinner
2008-03-05 20:43 ` Eric Sandeen
2008-03-05 21:00 ` David Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080305210035.GA155407@sgi.com \
--to=dgc@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs-dev@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.